third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2961613002: Slightly refactor StickyPositionScrollingConstraints API and add documentation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2961613002: Slightly refactor StickyPositionScrollingConstraints API and add documentation (Closed)

Patch Set: Add diagram + example Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index df2fe64f9ba73cea56d3ff69c7a1c947057d48e8..59c0a99a236a4492a1b78ff821589dec4388e177 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -328,25 +328,22 @@ void CompositedLayerMapping::UpdateStickyConstraints(

web_constraint.scroll_container_relative_containing_block_rect =

EnclosingIntRect(

constraints.ScrollContainerRelativeContainingBlockRect());

- LayoutBoxModelObject* sticky_box_shifting_ancestor =

- constraints.NearestStickyBoxShiftingStickyBox();

+ PaintLayer* sticky_box_shifting_ancestor =

+ constraints.NearestStickyLayerShiftingStickyBox();

if (sticky_box_shifting_ancestor &&

- sticky_box_shifting_ancestor->Layer()->GetCompositedLayerMapping()) {

+ sticky_box_shifting_ancestor->GetCompositedLayerMapping()) {

web_constraint.nearest_layer_shifting_sticky_box =

- sticky_box_shifting_ancestor->Layer()

- ->GetCompositedLayerMapping()

+ sticky_box_shifting_ancestor->GetCompositedLayerMapping()

->MainGraphicsLayer()

->PlatformLayer()

->Id();

}

- LayoutBoxModelObject* containing_block_shifting_ancestor =

- constraints.NearestStickyBoxShiftingContainingBlock();

+ PaintLayer* containing_block_shifting_ancestor =

+ constraints.NearestStickyLayerShiftingContainingBlock();

if (containing_block_shifting_ancestor &&

- containing_block_shifting_ancestor->Layer()

- ->GetCompositedLayerMapping()) {

+ containing_block_shifting_ancestor->GetCompositedLayerMapping()) {

web_constraint.nearest_layer_shifting_containing_block =

- containing_block_shifting_ancestor->Layer()

- ->GetCompositedLayerMapping()

+ containing_block_shifting_ancestor->GetCompositedLayerMapping()

->MainGraphicsLayer()

->PlatformLayer()

->Id();