Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: tests/compiler/dart2js/serialization/model_test_helper.dart

Issue 2961563003: Hopefully the last bit of restructuring between closture classes and loop boxing, etc. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« pkg/compiler/pubspec.yaml ('K') | « pkg/compiler/pubspec.yaml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.serialization_model_test; 5 library dart2js.serialization_model_test;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'package:async_helper/async_helper.dart'; 8 import 'package:async_helper/async_helper.dart';
9 import 'package:expect/expect.dart'; 9 import 'package:expect/expect.dart';
10 import 'package:compiler/src/closure.dart'; 10 import 'package:compiler/src/closure.dart';
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 if (a == null || b == null) return false; 257 if (a == null || b == null) return false;
258 if (!areLocalsEquivalent(a.boxElement, b.boxElement)) { 258 if (!areLocalsEquivalent(a.boxElement, b.boxElement)) {
259 return false; 259 return false;
260 } 260 }
261 checkMaps( 261 checkMaps(
262 a.capturedVariables, 262 a.capturedVariables,
263 b.capturedVariables, 263 b.capturedVariables,
264 'ClosureScope.capturedVariables', 264 'ClosureScope.capturedVariables',
265 areLocalsEquivalent, 265 areLocalsEquivalent,
266 areElementsEquivalent); 266 areElementsEquivalent);
267 checkSets(a.boxedLoopVariables, b.boxedLoopVariables,
Siggi Cherem (dart-lang) 2017/06/26 16:54:42 should we replace this somehow? One option would
Emily Fortuna 2017/06/26 21:57:20 Done.
268 'ClosureScope.boxedLoopVariables', areElementsEquivalent);
269 return true; 267 return true;
270 } 268 }
271 269
272 String nodeToString(Node node) { 270 String nodeToString(Node node) {
273 String text = '$node'; 271 String text = '$node';
274 if (text.length > 40) { 272 if (text.length > 40) {
275 return '(${node.runtimeType}) ${text.substring(0, 37)}...'; 273 return '(${node.runtimeType}) ${text.substring(0, 37)}...';
276 } 274 }
277 return '(${node.runtimeType}) $text'; 275 return '(${node.runtimeType}) $text';
278 } 276 }
(...skipping 13 matching lines...) Expand all
292 check(outputUnit1, outputUnit2, 'OutputUnit.isMainOutput $message', 290 check(outputUnit1, outputUnit2, 'OutputUnit.isMainOutput $message',
293 outputUnit1.isMainOutput, outputUnit2.isMainOutput); 291 outputUnit1.isMainOutput, outputUnit2.isMainOutput);
294 checkSetEquivalence( 292 checkSetEquivalence(
295 outputUnit1, 293 outputUnit1,
296 outputUnit2, 294 outputUnit2,
297 'OutputUnit.imports $message', 295 'OutputUnit.imports $message',
298 outputUnit1.imports, 296 outputUnit1.imports,
299 outputUnit2.imports, 297 outputUnit2.imports,
300 (a, b) => areElementsEquivalent(a.declaration, b.declaration)); 298 (a, b) => areElementsEquivalent(a.declaration, b.declaration));
301 } 299 }
OLDNEW
« pkg/compiler/pubspec.yaml ('K') | « pkg/compiler/pubspec.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698