Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 296153014: AttachmentDownloader implementation. (Closed)

Created:
6 years, 7 months ago by pavely
Modified:
6 years, 7 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

AttachmentDownloader implementation. This is rudimentary implemenatation of AttachmentDownloader along with fake for tests. BUG=376073 R=maniscalco@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -0 lines) Patch
A sync/internal_api/attachments/attachment_downloader_impl.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A sync/internal_api/attachments/attachment_downloader_impl_unittest.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A sync/internal_api/attachments/fake_attachment_downloader.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A sync/internal_api/attachments/fake_attachment_downloader_unittest.cc View 1 chunk +60 lines, -0 lines 0 comments Download
A sync/internal_api/public/attachments/attachment_downloader_impl.h View 1 chunk +30 lines, -0 lines 0 comments Download
A sync/internal_api/public/attachments/fake_attachment_downloader.h View 1 chunk +31 lines, -0 lines 0 comments Download
M sync/sync_internal_api.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M sync/sync_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pavely
6 years, 7 months ago (2014-05-23 21:39:13 UTC) #1
maniscalco
lgtm
6 years, 7 months ago (2014-05-23 23:00:22 UTC) #2
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 7 months ago (2014-05-23 23:01:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/296153014/1
6 years, 7 months ago (2014-05-23 23:02:08 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 13:10:33 UTC) #5
Message was sent while issue was closed.
Change committed as 272733

Powered by Google App Engine
This is Rietveld 408576698