sdk/lib/html/dart2js/html_dart2js.dart - Issue 296153013: Fixing iframe.contentWindow.postMessage passing incorrect data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 296153013: Fixing iframe.contentWindow.postMessage passing incorrect data (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index 38591f3430eb868050681c5d3bab19026139df6e..fa292d5bc588ed04dfd865696d0fd48914dbbb81 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -35344,9 +35344,12 @@ class _DOMWindowCrossFrame implements WindowBase {

void postMessage(var message, String targetOrigin, [List messagePorts = null]) {

if (messagePorts == null) {

- JS('void', '#.postMessage(#,#)', _window, message, targetOrigin);

+ JS('void', '#.postMessage(#,#)', _window,

+ convertDartToNative_SerializedScriptValue(message), targetOrigin);

} else {

- JS('void', '#.postMessage(#,#,#)', _window, message, targetOrigin, messagePorts);

+ JS('void', '#.postMessage(#,#,#)', _window,

+ convertDartToNative_SerializedScriptValue(message), targetOrigin,

+ messagePorts);

}

« no previous file with comments | « no previous file | tests/html/postmessage_structured_test.dart » ('j') | no next file with comments »