Issue 296153010: [chromedriver] Fix CHROME_36_REVISION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296153010: [chromedriver] Fix CHROME_36_REVISION (Closed)

Created:
6 years, 7 months ago by samuong

Modified:
6 years, 7 months ago

Reviewers:
stgao

CC:
chromium-reviews, stgao

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[chromedriver] Fix CHROME_36_REVISION BUG= NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272546

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/chromedriver/archive.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

samuong

CHROME_36_REVISION was set to 269467, which was available in the snapshot archive but not the ...

6 years, 7 months ago (2014-05-23 15:49:09 UTC) #1

stgao

https://codereview.chromium.org/296153010/diff/1/chrome/test/chromedriver/archive.py File chrome/test/chromedriver/archive.py (right): https://codereview.chromium.org/296153010/diff/1/chrome/test/chromedriver/archive.py#newcode15 chrome/test/chromedriver/archive.py:15: CHROME_36_REVISION = '269696' 269467 was the branched revision, so ...

6 years, 7 months ago (2014-05-23 16:08:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/296153010/1

6 years, 7 months ago (2014-05-23 16:37:00 UTC) #5

Message was sent while issue was closed.

Change committed as 272546

Expand Messages | Collapse Messages