Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 296153005: Oilpan: fix ImageBitmapTest.ImageLiveResourcePriority test. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: fix ImageBitmapTest.ImageLiveResourcePriority test. Hold onto the local HTMLImageElements using persistents so as to keep them alive across the forced GC that the test runs. R=haraken@chromium.org,ager@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174636

Patch Set 1 #

Patch Set 2 : Pull in needed wrapInShadowTemplate() fix #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/core/frame/ImageBitmapTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look. Had to pull in the unrelated wrapInShadowTemplate() tweak to make it ...
6 years, 7 months ago (2014-05-22 14:48:05 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-22 14:49:17 UTC) #2
Mads Ager (chromium)
LGTM, thanks!
6 years, 7 months ago (2014-05-22 15:00:51 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-22 18:23:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/296153005/40001
6 years, 7 months ago (2014-05-22 18:24:32 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 02:29:24 UTC) #6
Message was sent while issue was closed.
Change committed as 174636

Powered by Google App Engine
This is Rietveld 408576698