Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/gn/command_gen.cc

Issue 296153002: gn: Remove obsolete comment about gyp command. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_gen.cc
diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc
index b8e5e0fbb81d731b8c48bc106c34704c2fe04b0f..4b7886c59cf1c4fb4603148c6d17d8259d6e1e42 100644
--- a/tools/gn/command_gen.cc
+++ b/tools/gn/command_gen.cc
@@ -89,10 +89,7 @@ const char kGen_Help[] =
"\n"
" See \"gn help\" for the common command-line switches.\n";
-// Note: partially duplicated in command_gyp.cc.
int RunGen(const std::vector<std::string>& args) {
- base::ElapsedTimer timer;
-
if (args.size() != 1) {
Err(Location(), "Need exactly one build directory to generate.",
"I expected something more like \"gn gen out/foo\"\n"
@@ -100,6 +97,8 @@ int RunGen(const std::vector<std::string>& args) {
return 1;
}
+ base::ElapsedTimer timer;
scottmg 2014/05/21 20:34:42 i think probably leave this where it was?
tfarina 2014/05/21 20:39:44 OK. Done.
+
// Deliberately leaked to avoid expensive process teardown.
Setup* setup = new Setup();
if (!setup->DoSetup(args[0]))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698