Issue 296153002: gn: Remove obsolete comment about gyp command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296153002: gn: Remove obsolete comment about gyp command. (Closed)

Created:
6 years, 7 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, brettw

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gn: Remove obsolete comment about gyp command. BUG=None TEST=None R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271968

Patch Set 2 : leave #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	tools/gn/command_gen.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/296153002/diff/1/tools/gn/command_gen.cc File tools/gn/command_gen.cc (right): https://codereview.chromium.org/296153002/diff/1/tools/gn/command_gen.cc#newcode100 tools/gn/command_gen.cc:100: base::ElapsedTimer timer; i think probably leave this where ...

6 years, 7 months ago (2014-05-21 20:34:42 UTC) #2

tfarina

https://codereview.chromium.org/296153002/diff/1/tools/gn/command_gen.cc File tools/gn/command_gen.cc (right): https://codereview.chromium.org/296153002/diff/1/tools/gn/command_gen.cc#newcode100 tools/gn/command_gen.cc:100: base::ElapsedTimer timer; On 2014/05/21 20:34:42, scottmg wrote: > i ...

6 years, 7 months ago (2014-05-21 20:39:44 UTC) #3

tfarina

Committed patchset #2 manually as r271968 (presubmit successful).

6 years, 7 months ago (2014-05-21 20:41:35 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages

Issue 296153002: gn: Remove obsolete comment about gyp command. (Closed)

Description

Patch Set 1 #

Patch Set 2 : leave #

Messages