Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/browser/task_manager/task_manager_tester.cc

Issue 2961423002: [TaskManager] Allow a Task to mutate its PID after creation (Closed)
Patch Set: Rework comment. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/task_manager_browsertest_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/task_manager_tester.cc
diff --git a/chrome/browser/task_manager/task_manager_tester.cc b/chrome/browser/task_manager/task_manager_tester.cc
index f93a2497d90e585aa4565270c6aae8e647a32051..94d8d18bc13440e702a4aabb835b7619b726de03 100644
--- a/chrome/browser/task_manager/task_manager_tester.cc
+++ b/chrome/browser/task_manager/task_manager_tester.cc
@@ -99,6 +99,12 @@ void TaskManagerTester::ToggleColumnVisibility(ColumnSpecifier column) {
switch (column) {
case ColumnSpecifier::COLUMN_NONE:
return;
+ case ColumnSpecifier::PROCESS_ID:
+ column_id = IDS_TASK_MANAGER_PROCESS_ID_COLUMN;
+ break;
+ case ColumnSpecifier::PHYSICAL_MEMORY:
+ column_id = IDS_TASK_MANAGER_PHYSICAL_MEM_COLUMN;
+ break;
case ColumnSpecifier::SQLITE_MEMORY_USED:
column_id = IDS_TASK_MANAGER_SQLITE_MEMORY_USED_COLUMN;
break;
@@ -126,6 +132,14 @@ int64_t TaskManagerTester::GetColumnValue(ColumnSpecifier column, int row) {
case ColumnSpecifier::COLUMN_NONE:
case ColumnSpecifier::MEMORY_STATE:
break;
+ case ColumnSpecifier::PHYSICAL_MEMORY:
+ value = task_manager()->GetPhysicalMemoryUsage(task_id);
+ success = true;
+ break;
+ case ColumnSpecifier::PROCESS_ID:
+ value = static_cast<int64_t>(task_manager()->GetProcessId(task_id));
+ success = true;
+ break;
case ColumnSpecifier::V8_MEMORY:
success = task_manager()->GetV8Memory(task_id, &value, &ignored);
break;
« no previous file with comments | « chrome/browser/task_manager/task_manager_browsertest_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698