[TaskManager] Allow a Task to mutate its PID after creation

chrome/browser/task_manager/providers/task.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TASK_MANAGER_PROVIDERS_TASK_H_
 #define CHROME_BROWSER_TASK_MANAGER_PROVIDERS_TASK_H_
 
 #include <stdint.h>
 
 #include <string>
 
 #include "base/macros.h"
 #include "base/process/kill.h"
 #include "base/process/process_handle.h"
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "third_party/WebKit/public/platform/WebCache.h"
 #include "ui/gfx/image/image_skia.h"
 
 class Profile;
 
 namespace task_manager {
 
+class TaskProviderObserver;
+
 // Defines a task that corresponds to a tab, an app, an extension, ... etc. It
 // represents one row in the task manager table. Multiple tasks can share the
 // same process, in which case they're grouped together in the task manager
 // table. See |task_manager::TaskGroup| which represents a process possibly
 // shared by multiple tasks.
 class Task {
  public:
   // Note that the declaration order here determines the default sort order
   // in the task manager.
   enum Type {
@@ skipping 42 matching lines @@
   // Kills this task.
   virtual void Kill();
 
   // Will be called to let the task refresh itself between refresh cycles.
   // |update_interval| is the time since the last task manager refresh.
   // the |refresh_flags| indicate which resources should be calculated on each
   // refresh.
   virtual void Refresh(const base::TimeDelta& update_interval,
                        int64_t refresh_flags);
 
+  // Temporarily remove a task, change its process ID, and then re-add it.

[afakhry, 2017/08/01 17:25:35]

Nit: Looking at this comment again, I think it would be better to change it. For
example:

- ("this" task) instead of ("a" task).
- remove and re-add where? To |observer| for instance.

I'll leave the wording for you since you're better than me at this! :)

[ncarter (slow), 2017/08/01 23:07:09]

Done.

+  void UpdateProcessInfo(base::ProcessHandle handle,
+                         base::ProcessId process_id,
+                         TaskProviderObserver* observer);
+
   // Will receive this notification through the task manager from
   // |ChromeNetworkDelegate::OnNetworkBytesReceived()|. The task will add to the
   // |current_byte_count_| in this refresh cycle.
   void OnNetworkBytesRead(int64_t bytes_read);
 
   // Returns the task type.
   virtual Type GetType() const = 0;
 
   // This is the unique ID of the BrowserChildProcessHost/RenderProcessHost. It
   // is not the PID nor the handle of the process.
@@ skipping 77 matching lines @@
   base::string16 title_;
 
   // The name of the sample representing this task when a Rappor sample needs to
   // be recorded for it.
   std::string rappor_sample_name_;
 
   // The favicon.
   gfx::ImageSkia icon_;
 
   // The handle of the process on which this task is running.
-  const base::ProcessHandle process_handle_;
+  base::ProcessHandle process_handle_;
 
   // The PID of the process on which this task is running.
-  const base::ProcessId process_id_;
+  base::ProcessId process_id_;
 
   DISALLOW_COPY_AND_ASSIGN(Task);
 };
 
 }  // namespace task_manager
 
 #endif  // CHROME_BROWSER_TASK_MANAGER_PROVIDERS_TASK_H_