Omnibox UI Experiments: Hook up elide-after-host feature flag.

components/omnibox/browser/omnibox_field_trial.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
 #define COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 17 matching lines @@
 extern const base::Feature kOmniboxEntitySuggestions;
 extern const base::Feature kOmniboxTailSuggestions;
 extern const base::Feature kEnableClipboardProvider;
 extern const base::Feature kAndroidFakeboxDemotion;
 extern const base::Feature kAndroidFakeboxDemotionOnPhones;
 extern const base::Feature kSearchProviderWarmUpOnFocus;
 extern const base::Feature kSearchProviderContextAllowHttpsUrls;
 extern const base::Feature kZeroSuggestRedirectToChrome;
 extern const base::Feature kZeroSuggestSwapTitleAndUrl;
 extern const base::Feature kDisplayTitleForCurrentUrl;
-extern const base::Feature kUIExperimentHideSuggestionUrlPath;

[Mark P, 2017/07/05 18:38:45]

As near as I can tell, you checked in this declaration for a feature flag that
wasn't used.  Is that correct?

[tommycli, 2017/07/05 19:38:26]

Hey... I wasn't able to grok your question -- do you mind rephrasing it?

The feature flag used to be called "hide suggestion url path", but wasn't
implemented yet... it was just a placeholder feature flag.

Through the course of implementation, Peter suggested that a more accurate name
would be "elide suggestion url after host" -- so I'm updating the feature flag
name to more accurately reflect what's going on.

[Mark P, 2017/07/05 19:43:24]

You answered my question. :-)  It was a placeholder declaration.

+extern const base::Feature kUIExperimentElideSuggestionUrlAfterHost;
 extern const base::Feature kUIExperimentHideSuggestionUrlScheme;
 extern const base::Feature kUIExperimentHideSuggestionUrlTrivialSubdomains;
 extern const base::Feature kUIExperimentMaxAutocompleteMatches;
 extern const base::Feature kUIExperimentNarrowDropdown;
 extern const base::Feature kUIExperimentVerticalLayout;
 extern const base::Feature kUIExperimentVerticalMargin;
 }
 
 // The set of parameters customizing the HUP scoring.
 struct HUPScoringParams {
@@ skipping 498 matching lines @@
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       metrics::OmniboxEventProto::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_