Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4829)

Unified Diff: chrome/renderer/plugins/pdf_plugin_placeholder.h

Issue 2961383002: Show a new placeholder for PDF's when plugins are disabled. (Closed)
Patch Set: Add comments, change function name and arguments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/plugins/pdf_plugin_placeholder.h
diff --git a/chrome/renderer/plugins/pdf_plugin_placeholder.h b/chrome/renderer/plugins/pdf_plugin_placeholder.h
new file mode 100644
index 0000000000000000000000000000000000000000..11e9f66d961590da0ae332b52963466829177e0b
--- /dev/null
+++ b/chrome/renderer/plugins/pdf_plugin_placeholder.h
@@ -0,0 +1,32 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_
+#define CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_
+
+#include "components/plugins/renderer/plugin_placeholder.h"
+
+// Creates a placeholder that allows users to click to download a PDF for when
+// plugins are disabled and the PDF fails to load.
+// TODO(amberwon): Flesh out the class more.
tommycli 2017/06/30 15:31:18 "...to download an embedded PDF when the PDF plugi
amberwon 2017/06/30 17:35:54 Done.
+class PDFPluginPlaceholder final : public plugins::PluginPlaceholderBase,
+ public gin::Wrappable<PDFPluginPlaceholder> {
+ public:
+ static gin::WrapperInfo kWrapperInfo;
+
+ static PDFPluginPlaceholder* CreatePDFPlaceholder(
+ content::RenderFrame* render_frame,
+ const blink::WebPluginParams& params);
+
+ private:
+ PDFPluginPlaceholder(content::RenderFrame* render_frame,
+ const blink::WebPluginParams& params,
+ const std::string& html_data);
+ ~PDFPluginPlaceholder() override;
+
+ // WebViewPlugin::Delegate methods:
+ v8::Local<v8::Value> GetV8Handle(v8::Isolate* isolate) final;
+};
+
+#endif // CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/plugins/pdf_plugin_placeholder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698