Show a new placeholder for PDF's when plugins are disabled.

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index fa44f43c2856ea1a3dafe15368be605bfb5da430..789922e0653efb13e12a5501de08ae6c13cb59b9 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -51,6 +51,7 @@
 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
 #include "chrome/renderer/pepper/pepper_helper.h"
 #include "chrome/renderer/plugins/non_loadable_plugin_placeholder.h"
+#include "chrome/renderer/plugins/pdf_plugin_placeholder.h"
 #include "chrome/renderer/plugins/plugin_preroller.h"
 #include "chrome/renderer/plugins/plugin_uma.h"
 #include "chrome/renderer/prerender/prerender_dispatcher.h"
@@ -883,6 +884,13 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
             ASCIIToUTF16(ChromeContentClient::kPDFExtensionPluginName)) {
           ReportPDFLoadStatus(
               PDFLoadStatus::kShowedDisabledPluginPlaceholderForEmbeddedPdf);
+
+          if (base::FeatureList::IsEnabled(
+                  features::kClickToOpenPDFPlaceholder)) {
+            return PDFPluginPlaceholder::CreateBlockedPlugin(
+                       render_frame, params, IDR_PDF_PLUGIN_HTML)
+                ->plugin();

[tommycli, 2017/06/29 23:31:41]

Worth adding a comment indicating that the placeholder is owned by the returned
plugin.

[amberwon, 2017/06/30 01:18:53]

Done.

+          }
         }
 
         placeholder = create_blocked_plugin(