Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4327)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2961383002: Show a new placeholder for PDF's when plugins are disabled. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/BUILD.gn ('k') | chrome/renderer/plugins/pdf_plugin_placeholder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index fa44f43c2856ea1a3dafe15368be605bfb5da430..c07c08482827bc98aed3b0e185cc8fc5ca507db3 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -51,6 +51,7 @@
#include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
#include "chrome/renderer/pepper/pepper_helper.h"
#include "chrome/renderer/plugins/non_loadable_plugin_placeholder.h"
+#include "chrome/renderer/plugins/pdf_plugin_placeholder.h"
#include "chrome/renderer/plugins/plugin_preroller.h"
#include "chrome/renderer/plugins/plugin_uma.h"
#include "chrome/renderer/prerender/prerender_dispatcher.h"
@@ -883,6 +884,13 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
ASCIIToUTF16(ChromeContentClient::kPDFExtensionPluginName)) {
ReportPDFLoadStatus(
PDFLoadStatus::kShowedDisabledPluginPlaceholderForEmbeddedPdf);
+
+ if (base::FeatureList::IsEnabled(
+ features::kClickToOpenPDFPlaceholder)) {
+ return PDFPluginPlaceholder::CreatePDFPlaceholder(render_frame,
+ params)
+ ->plugin();
+ }
}
placeholder = create_blocked_plugin(
« no previous file with comments | « chrome/renderer/BUILD.gn ('k') | chrome/renderer/plugins/pdf_plugin_placeholder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698