Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: chrome/renderer/plugins/pdf_plugin_placeholder.h

Issue 2961383002: Show a new placeholder for PDF's when plugins are disabled. (Closed)
Patch Set: Forgot parentheses Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_
6 #define CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_
7
8 #include "components/plugins/renderer/plugin_placeholder.h"
9
10 class PDFPluginPlaceholder final : public plugins::PluginPlaceholderBase,
tommycli 2017/06/29 23:31:41 Add a comment as to the purpose of the class. And
amberwon 2017/06/30 01:18:53 Done.
11 public gin::Wrappable<PDFPluginPlaceholder> {
12 public:
13 static gin::WrapperInfo kWrapperInfo;
14 static PDFPluginPlaceholder* CreateBlockedPlugin(
tommycli 2017/06/29 23:31:41 Should probably be CreatePDFPlaceholder ... and th
amberwon 2017/06/30 01:18:53 Done.
15 content::RenderFrame* render_frame,
16 const blink::WebPluginParams& params,
17 int template_id);
18
19 private:
20 PDFPluginPlaceholder(content::RenderFrame* render_frame,
21 const blink::WebPluginParams& params,
22 const std::string& html_data);
23 ~PDFPluginPlaceholder() override;
24
25 // WebViewPlugin::Delegate methods:
26 v8::Local<v8::Value> GetV8Handle(v8::Isolate* isolate) final;
27 };
28
29 #endif // CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698