chrome/test/data/safe_browsing/mach_o/Makefile - Issue 2961373002: Improve Zip File Scanning on Mac

Side by Side Diff: chrome/test/data/safe_browsing/mach_o/Makefile

Issue 2961373002: Improve Zip File Scanning on Mac (Closed)

Patch Set: removing check for .app on windows Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/common/safe_browsing/zip_analyzer.cc ('k') | chrome/test/data/safe_browsing/mach_o/zipped-app-with-executable.zip » ('j') | third_party/zlib/google/zip_reader.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 KEYCHAIN_PASSWORD=g0atMaster	5 KEYCHAIN_PASSWORD=g0atMaster

6 # This must match the commonName in codesign.cfg.	6 # This must match the commonName in codesign.cfg.

7 KEYCHAIN_IDENTITY=untrusted@goat.local	7 KEYCHAIN_IDENTITY=untrusted@goat.local

8	8

9 # Funcitons to add and remove codesigning identity to user's keychain. These	9 # Funcitons to add and remove codesigning identity to user's keychain. These

10 # are necessary since the codesign utility no longer supports the -k option,	10 # are necessary since the codesign utility no longer supports the -k option,

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 codesign -s $(KEYCHAIN_IDENTITY) $@ --all-architectures	58 codesign -s $(KEYCHAIN_IDENTITY) $@ --all-architectures

59 $(call post-build)	59 $(call post-build)

60	60

61 signed-archive.dmg: test-bundle.app codesign.crt	61 signed-archive.dmg: test-bundle.app codesign.crt

62 $(call pre-build)	62 $(call pre-build)

63 hdiutil create -srcfolder test-bundle.app -format UDZO -layout \	63 hdiutil create -srcfolder test-bundle.app -format UDZO -layout \

64 SPUD -volname "Signed Archive" -ov $@	64 SPUD -volname "Signed Archive" -ov $@

65 codesign -s $(KEYCHAIN_IDENTITY) $@	65 codesign -s $(KEYCHAIN_IDENTITY) $@

66 $(call post-build)	66 $(call post-build)

67	67

	68 zipped-app-with-executable.zip: executablefat

	69 ditto base-bundle.app app-with-executable.app

	70 ditto $< app-with-executable.app/Contents/MacOS/

	71 zip -r $@ app-with-executable.app

	72 rm -r app-with-executable.app

	73

68 .PHONY: test-bundle.app	74 .PHONY: test-bundle.app

69 test-bundle.app: signedexecutablefat libsigned64.dylib executable32	75 test-bundle.app: signedexecutablefat libsigned64.dylib executable32

70 $(call pre-build)	76 $(call pre-build)

71 ditto base-bundle.app $@	77 ditto base-bundle.app $@

72 ditto $< $@/Contents/MacOS/test-bundle	78 ditto $< $@/Contents/MacOS/test-bundle

73 ditto $(word 2,$^) $@/Contents/Frameworks/$(word 2,$^)	79 ditto $(word 2,$^) $@/Contents/Frameworks/$(word 2,$^)

74 ditto $(word 3,$^) $@/Contents/Resources/$(word 3,$^)	80 ditto $(word 3,$^) $@/Contents/Resources/$(word 3,$^)

75 codesign -f -s $(KEYCHAIN_IDENTITY) $@ --all-architectures \	81 codesign -f -s $(KEYCHAIN_IDENTITY) $@ --all-architectures \

76 --resource-rules ResourceRules	82 --resource-rules ResourceRules

77 $(call post-build)	83 $(call post-build)

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
115	121

116 .PHONY: modified-localization.app	122 .PHONY: modified-localization.app

117 modified-localization.app: test-bundle.app	123 modified-localization.app: test-bundle.app

118 $(call pre-build)	124 $(call pre-build)

119 ditto $< $@	125 ditto $< $@

120 echo "<xml/>" > $@/Contents/Resources/Base.lproj/InfoPlist.strings	126 echo "<xml/>" > $@/Contents/Resources/Base.lproj/InfoPlist.strings

121 codesign -f -s $(KEYCHAIN_IDENTITY) $@ --all-architectures \	127 codesign -f -s $(KEYCHAIN_IDENTITY) $@ --all-architectures \

122 --resource-rules ResourceRules	128 --resource-rules ResourceRules

123 echo "CORRUPT" > $@/Contents/Resources/Base.lproj/InfoPlist.strings	129 echo "CORRUPT" > $@/Contents/Resources/Base.lproj/InfoPlist.strings

124 $(call post-build)	130 $(call post-build)

OLD	NEW