Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2961363003: Stop using ExecutableElement.localVariables in RenameClassMemberRefactoringImpl. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop using ExecutableElement.localVariables in RenameClassMemberRefactoringImpl. This is the only / last usage in Analysis Server. And this change fixes 3 failing tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/238894eb76f54709a7bfdff7c1a8f9db19677de0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -43 lines) Patch
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 4 chunks +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 4 chunks +15 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 8 chunks +57 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-06-30 18:51:00 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-06-30 18:53:44 UTC) #2
scheglov
3 years, 5 months ago (2017-06-30 18:58:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
238894eb76f54709a7bfdff7c1a8f9db19677de0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698