Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 296133015: Remove OVERRIDEs in RendererWebKitPlatformSupportImpl. (Closed)

Created:
6 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove OVERRIDEs in RendererWebKitPlatformSupportImpl. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272714

Patch Set 1 #

Patch Set 2 : without presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M content/renderer/renderer_webkitplatformsupport_impl.h View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mlamouri (slow - plz ping)
Following comments in https://codereview.chromium.org/283423005/
6 years, 7 months ago (2014-05-23 14:36:38 UTC) #1
jochen (gone - plz use gerrit)
i don't think the PRESUBMIT check is a good idea. we might want to override ...
6 years, 7 months ago (2014-05-23 14:41:00 UTC) #2
mlamouri (slow - plz ping)
On 2014/05/23 14:41:00, jochen wrote: > i don't think the PRESUBMIT check is a good ...
6 years, 7 months ago (2014-05-23 14:51:46 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-23 14:55:31 UTC) #4
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 7 months ago (2014-05-23 15:01:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/296133015/20001
6 years, 7 months ago (2014-05-23 15:02:08 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 19:13:32 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 21:37:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/32178)
6 years, 7 months ago (2014-05-23 21:37:43 UTC) #9
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 7 months ago (2014-05-24 10:46:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/296133015/20001
6 years, 7 months ago (2014-05-24 10:46:29 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 12:27:28 UTC) #12
Message was sent while issue was closed.
Change committed as 272714

Powered by Google App Engine
This is Rietveld 408576698