Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 296133012: Some security checks around destruction/setting bounds. (Closed)

Created:
6 years, 7 months ago by Ben Goodger (Google)
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Some security checks around destruction/setting bounds. . validate on the client that the node can only be deleted or have its bounds changed by the connection that created the node. note that it's still possible for the client to call the interface directly, but the service will validate also, and then the client's inconsistent state is the client's own fault. . pass bounds through the INodes array R=sky@chromium.org http://crbug.com/365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273116

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -4 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node.cc View 1 2 6 chunks +18 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 2 3 4 chunks +60 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/node.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ben Goodger (Google)
6 years, 7 months ago (2014-05-23 00:13:17 UTC) #1
sky
LGTM https://codereview.chromium.org/296133012/diff/1/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc File mojo/services/public/cpp/view_manager/lib/view_tree_node.cc (right): https://codereview.chromium.org/296133012/diff/1/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc#newcode184 mojo/services/public/cpp/view_manager/lib/view_tree_node.cc:184: bool CanMutateNode(ViewManager* manager, ViewTreeNode* node) { Maybe this ...
6 years, 7 months ago (2014-05-23 13:16:28 UTC) #2
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 7 months ago (2014-05-27 18:02:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/296133012/60001
6 years, 7 months ago (2014-05-27 18:03:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-27 22:48:54 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 02:42:27 UTC) #6
Message was sent while issue was closed.
Change committed as 273116

Powered by Google App Engine
This is Rietveld 408576698