Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 296133011: Move extension API schema registration to ExtensionsClient. (Closed)

Created:
6 years, 7 months ago by Yoyo Zhou
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move extension API schema registration to ExtensionsClient. BUG=368334 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272696

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : ifdefs =( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -31 lines) Patch
M apps/shell/common/shell_extensions_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M apps/shell/common/shell_extensions_client.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 2 3 chunks +40 lines, -0 lines 0 comments Download
M extensions/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/extension_api.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/common/extension_api.cc View 2 chunks +1 line, -29 lines 0 comments Download
M extensions/common/extensions_client.h View 2 chunks +6 lines, -1 line 0 comments Download
M extensions/test/test_extensions_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/test/test_extensions_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Yoyo Zhou
6 years, 7 months ago (2014-05-22 21:59:52 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 7 months ago (2014-05-23 00:24:54 UTC) #2
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 7 months ago (2014-05-23 01:02:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/296133011/20001
6 years, 7 months ago (2014-05-23 01:03:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 05:13:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 05:23:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/145287)
6 years, 7 months ago (2014-05-23 05:23:10 UTC) #7
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-05-23 20:50:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/296133011/20001
6 years, 7 months ago (2014-05-23 20:50:56 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 21:13:15 UTC) #10
Yoyo Zhou
The CQ bit was unchecked by yoz@chromium.org
6 years, 7 months ago (2014-05-23 21:28:20 UTC) #11
Yoyo Zhou
I had to add ifdefs for ENABLE_EXTENSIONS. =( That's a temporary solution though. The existing ...
6 years, 7 months ago (2014-05-23 23:02:27 UTC) #12
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 7 months ago (2014-05-23 23:02:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/296133011/40001
6 years, 7 months ago (2014-05-23 23:04:18 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 03:14:49 UTC) #15
Message was sent while issue was closed.
Change committed as 272696

Powered by Google App Engine
This is Rietveld 408576698