Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 296133007: Disable multisampling on Mali-400 GPUs and Android < 4.3 (Closed)

Created:
6 years, 7 months ago by tsniatowski
Modified:
6 years, 7 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable multisampling on Mali-400 GPUs and Android < 4.3 This avoids a GL error from a buggy glGetIntegerv(GL_MAX_SAMPLES_ANGLE) call. Based on patch by mkisilev@yandex-team.ru BUG=362435 R=sievers@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272874

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase and add version bump #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tsniatowski
6 years, 7 months ago (2014-05-22 09:22:47 UTC) #1
no sievers
https://codereview.chromium.org/296133007/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/296133007/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "5.4", Can you bump this version?
6 years, 7 months ago (2014-05-22 17:22:03 UTC) #2
mkisilev
You probably would meet this problem: https://codereview.chromium.org/292153009/#msg8
6 years, 7 months ago (2014-05-22 22:20:00 UTC) #3
no sievers
LGTM, but please bump the version. And if you end up having to rebase (crrev.com/272261) ...
6 years, 7 months ago (2014-05-22 23:50:57 UTC) #4
tsniatowski
The CQ bit was checked by tsniatowski@opera.com
6 years, 7 months ago (2014-05-26 08:07:53 UTC) #5
tsniatowski
The CQ bit was unchecked by tsniatowski@opera.com
6 years, 7 months ago (2014-05-26 08:07:53 UTC) #6
tsniatowski
The CQ bit was checked by tsniatowski@opera.com
6 years, 7 months ago (2014-05-26 08:08:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsniatowski@opera.com/296133007/20001
6 years, 7 months ago (2014-05-26 08:09:13 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 11:43:15 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 20:15:30 UTC) #10
Message was sent while issue was closed.
Change committed as 272874

Powered by Google App Engine
This is Rietveld 408576698