Issue 296133006: Remove check for SAHF support in ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296133006: Remove check for SAHF support in ia32. (Closed)

Created:
6 years, 7 months ago by Yang

Modified:
6 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove check for SAHF support in ia32. On ia32, SAHF is guaranteed. It's only necessary to probe for it on x64. R=svenpanne@chromium.org BUG=376087 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21422

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	src/ia32/assembler-ia32.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Sven Panne

LGTM. Another more radical solution would be removing sahf/SAHF completely, we don't use it at ...

6 years, 7 months ago (2014-05-22 07:42:45 UTC) #2

Yang

On 2014/05/22 07:42:45, Sven Panne wrote: > LGTM. Another more radical solution would be removing ...

6 years, 7 months ago (2014-05-22 07:44:00 UTC) #3

Yang

6 years, 7 months ago (2014-05-22 08:04:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21422 (presubmit successful).