Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1981)

Unified Diff: ash/system/tray/system_tray.h

Issue 2961313003: Touch gestures for System Tray/ IME/ Stylus/ Notifications (Closed)
Patch Set: Fixed UT. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/tray/system_tray.h
diff --git a/ash/system/tray/system_tray.h b/ash/system/tray/system_tray.h
index 42a245719b1a0af5e27f3c06a91eaef6751e611e..3a3b254ee8ce3136e4cde08a2a72931de378f436 100644
--- a/ash/system/tray/system_tray.h
+++ b/ash/system/tray/system_tray.h
@@ -47,8 +47,6 @@ enum BubbleCreationType {
class ASH_EXPORT SystemTray : public TrayBackgroundView,
public views::TrayBubbleView::Delegate {
public:
- // The threshold of the velocity of the fling event.
- static constexpr float kFlingVelocity = 100.0f;
explicit SystemTray(Shelf* shelf);
~SystemTray() override;
@@ -124,13 +122,18 @@ class ASH_EXPORT SystemTray : public TrayBackgroundView,
// Returns TrayAudio object if present or null otherwise.
TrayAudio* GetTrayAudio() const;
- // Overridden from TrayBackgroundView.
+ // TrayBackgroundView:
void UpdateAfterShelfAlignmentChange() override;
void AnchorUpdated() override;
base::string16 GetAccessibleNameForTray() override;
void BubbleResized(const views::TrayBubbleView* bubble_view) override;
void HideBubbleWithView(const views::TrayBubbleView* bubble_view) override;
void ClickedOutsideBubble() override;
+ bool PerformAction(const ui::Event& event) override;
+ void CloseBubble() override;
+ void ShowBubble() override;
+ views::TrayBubbleView* GetBubbleView() override;
+ void OnGestureEvent(ui::GestureEvent* event) override;
// views::TrayBubbleView::Delegate:
void BubbleViewDestroyed() override;
@@ -143,6 +146,7 @@ class ASH_EXPORT SystemTray : public TrayBackgroundView,
base::string16 GetAccessibleNameForBubble() override;
bool ShouldEnableExtraKeyboardAccessibility() override;
void HideBubble(const views::TrayBubbleView* bubble_view) override;
+ bool ProcessGestureEventForBubble(ui::GestureEvent* event) override;
ScreenTrayItem* GetScreenShareItem() { return screen_share_tray_item_; }
ScreenTrayItem* GetScreenCaptureItem() { return screen_capture_tray_item_; }
@@ -150,11 +154,6 @@ class ASH_EXPORT SystemTray : public TrayBackgroundView,
// Activates the system tray bubble.
void ActivateBubble();
- // ui::EventHandler:
- void OnGestureEvent(ui::GestureEvent* event) override;
-
- gfx::Rect GetWorkAreaBoundsInScreen() const;
-
private:
friend class SystemTrayTestApi;
class ActivationObserver;
@@ -196,40 +195,6 @@ class ASH_EXPORT SystemTray : public TrayBackgroundView,
// and the percentage of the work area height covered by the system menu.
void RecordSystemMenuMetrics();
- // Overridden from ActionableView.
- bool PerformAction(const ui::Event& event) override;
-
- // Gesture related functions:
- bool ProcessGestureEvent(const ui::GestureEvent& event);
- bool StartGestureDrag(const ui::GestureEvent& gesture);
- void UpdateGestureDrag(const ui::GestureEvent& gesture);
- void CompleteGestureDrag(const ui::GestureEvent& gesture);
-
- // Update the bounds of the system tray bubble according to |location|. Note
- // that |location| is in the local coordinate space of |this|.
- void SetBubbleBounds(const gfx::Point& location);
-
- // Return true if the system bubble should be shown (i.e., animated upward to
- // be made fully visible) after a sequence of scroll events terminated by
- // |sequence_end|. Otherwise return false, indicating that the
- // partially-visible system bubble should be animated downward and made fully
- // hidden.
- bool ShouldShowSystemBubbleAfterScrollSequence(
- const ui::GestureEvent& sequence_end);
-
- // Shelf the system tray is in.
- Shelf* const shelf_;
-
- // The original bounds of the system tray bubble.
- gfx::Rect system_tray_bubble_bounds_;
-
- // Tracks the amount of the drag. Only valid if |is_in_drag_| is true.
- float gesture_drag_amount_ = 0.f;
-
- // True if the user is in the process of gesture-dragging to open the system
- // tray bubble, false otherwise.
- bool is_in_drag_ = false;
-
// The web notification tray view that appears adjacent to this view.
WebNotificationTray* web_notification_tray_ = nullptr;

Powered by Google App Engine
This is Rietveld 408576698