Touch gestures for System Tray/ IME/ Stylus/ Notifications

ash/system/tray/tray_background_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SYSTEM_TRAY_TRAY_BACKGROUND_VIEW_H_
 #define ASH_SYSTEM_TRAY_TRAY_BACKGROUND_VIEW_H_
 
 #include <memory>
 
 #include "ash/ash_export.h"
 #include "ash/shelf/shelf_background_animator_observer.h"
 #include "ash/system/tray/actionable_view.h"
+#include "ash/system/tray_drag_controller.h"
 #include "base/macros.h"
 #include "ui/compositor/layer_animation_observer.h"
 #include "ui/gfx/geometry/insets.h"
 #include "ui/views/bubble/tray_bubble_view.h"
 
 namespace ash {
 class Shelf;
 class TrayBackground;
 class TrayContainer;
 class TrayEventFilter;
@@ skipping 23 matching lines @@
   void ChildPreferredSizeChanged(views::View* child) override;
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
   void AboutToRequestFocusFromTabTraversal(bool reverse) override;
 
   // ActionableView:
   std::unique_ptr<views::InkDropRipple> CreateInkDropRipple() const override;
   std::unique_ptr<views::InkDropHighlight> CreateInkDropHighlight()
       const override;
   void PaintButtonContents(gfx::Canvas* canvas) override;
 
+  // Dragging releated functions:

[msw, 2017/07/12 05:04:52]

Add an explanatory comment for each function, nothing here is obviously related
to dragging. (also 'related' is spelled incorrectly)

[minch1, 2017/07/13 19:10:36]

Done.

+  virtual bool HasBubble();

[msw, 2017/07/12 05:04:52]

This function seems unnecessary, as callers can instead just check
GetBubbleView() for null, right? Avoid adding redundant functionality.

[minch1, 2017/07/13 19:10:36]

In SystemTray, HasBubble has a little bit different with others, it should be
|full_system_tray_menu_| (if there is single line bubble like the volume slider
opened, swiping the system tray area should still open the system tray bubble).
But I moved the logic to GetBubbleView instead, then we don't need HasBubble.

+  virtual views::TrayBubbleView* GetBubbleView();
+  virtual void CloseBubble() {}
+  virtual void ShowBubble() {}
+
   // Called whenever the shelf alignment changes.
   virtual void UpdateAfterShelfAlignmentChange();
 
   // Called when the anchor (tray or bubble) may have moved or changed.
   virtual void AnchorUpdated() {}
 
   // Called from GetAccessibleNodeData, must return a valid accessible name.
   virtual base::string16 GetAccessibleNameForTray() = 0;
 
   // Called when the bubble is resized.
@@ skipping 27 matching lines @@
   void set_separator_visibility(bool visible) { separator_visible_ = visible; }
 
   // Gets the anchor for bubbles, which is tray_container().
   views::View* GetBubbleAnchor() const;
 
   // Gets additional insets for positioning bubbles relative to
   // tray_container().
   gfx::Insets GetBubbleAnchorInsets() const;
 
   // Returns the container window for the bubble (on the proper display).
-  aura::Window* GetBubbleWindowContainer() const;
+  aura::Window* GetBubbleWindowContainer();
+
+  // Update the bounds of the tray bubbles. Close the bubble if

[msw, 2017/07/12 05:04:52]

nit: "of the associated tray bubble.", update line wrapping

[minch1, 2017/07/13 19:10:36]

Done.

+  // |close_bubble| is set.
+  void AnimateToTargetBounds(const gfx::Rect& target_bounds, bool close_bubble);
 
  protected:
   // ActionableView:
   std::unique_ptr<views::InkDropMask> CreateInkDropMask() const override;
   bool ShouldEnterPushedState(const ui::Event& event) override;
   bool PerformAction(const ui::Event& event) override;
   void HandlePerformActionResult(bool action_performed,
                                  const ui::Event& event) override;
 
+  TrayDragController* drag_controller() { return drag_controller_.get(); }
+
  private:
   class TrayWidgetObserver;
 
   // ui::ImplicitAnimationObserver:
   void OnImplicitAnimationsCompleted() override;
   bool RequiresNotificationWhenAnimatorDestroyed() const override;
 
   // Applies transformations to the |layer()| to animate the view when
   // SetVisible(false) is called.
   void HideTransformation();
@@ skipping 15 matching lines @@
   TrayBackground* background_;
 
   // Determines if the view is active. This changes how  the ink drop ripples
   // behave.
   bool is_active_;
 
   // Visibility of this tray's separator which is a line of 1x32px and 4px to
   // right of tray.
   bool separator_visible_;
 
+  std::unique_ptr<TrayDragController> drag_controller_;

[msw, 2017/07/12 05:04:52]

nit: add a comment.

[minch1, 2017/07/13 19:10:36]

Done.

+
+  // Used in maximize mode to make sure the system tray bubble only be shown in
+  // work area.
+  std::unique_ptr<aura::Window> clipping_window_;
+
   std::unique_ptr<TrayWidgetObserver> widget_observer_;
   std::unique_ptr<TrayEventFilter> tray_event_filter_;
 
   DISALLOW_COPY_AND_ASSIGN(TrayBackgroundView);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SYSTEM_TRAY_TRAY_BACKGROUND_VIEW_H_