Touch gestures for System Tray/ IME/ Stylus/ Notifications

ash/system/ime_menu/ime_menu_tray.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/ime_menu/ime_menu_tray.h"
 
 #include "ash/accelerators/accelerator_controller.h"
 #include "ash/accessibility_delegate.h"
 #include "ash/ash_constants.h"
 #include "ash/ime/ime_controller.h"
@@ skipping 452 matching lines @@
 }
 
 bool ImeMenuTray::PerformAction(const ui::Event& event) {
   if (bubble_)
     HideImeMenuBubble();
   else
     ShowImeMenuBubble();
   return true;
 }
 
+bool ImeMenuTray::HasBubble() {
+  return bubble_.get() != NULL;

[msw, 2017/07/12 05:04:50]

nit: this should be moot, but use nullptr instead of NULL.

[minch1, 2017/07/13 19:10:34]

Done.

+}
+
+void ImeMenuTray::CloseBubble() {
+  HideImeMenuBubble();
+}
+
+void ImeMenuTray::ShowBubble() {
+  ShowImeMenuBubble();
+}
+
+views::TrayBubbleView* ImeMenuTray::GetBubbleView() {
+  if (HasBubble())

[msw, 2017/07/12 05:04:50]

nit: return bubble_ ? bubble_->bubble_view() : nullptr;
(ditto elsewhere for the other impls)

[minch1, 2017/07/13 19:10:34]

Done.

+    return bubble_->bubble_view();
+  return nullptr;
+}
+
+void ImeMenuTray::OnGestureEvent(ui::GestureEvent* event) {
+  if (drag_controller()->ProcessGestureEvent(*event, this,
+                                             false /* is_on_bubble */)) {
+    event->SetHandled();

[msw, 2017/07/12 05:04:50]

Please make DragController::ProcessGestureEvent take an event pointer and call
SetHandled() on it directly (as needed), so each caller doesn't have to do this,
and then you can simplify the callers like this:
  if (!drag_controller()->ProcessGestureEvent(event, this, false)
    TrayBackgroundView::OnGestureEvent(event);

[minch1, 2017/07/13 19:10:34]

Done.

+  } else {
+    TrayBackgroundView::OnGestureEvent(event);
+  }
+}
+
 void ImeMenuTray::OnIMERefresh() {
   UpdateTrayLabel();
   if (bubble_ && ime_list_view_) {
     ime_list_view_->Update(ime_controller_->current_ime().id,
                            ime_controller_->available_imes(),
                            ime_controller_->current_ime_menu_items(), false,
                            ImeListView::SHOW_SINGLE_IME);
   }
 }
 
@@ skipping 29 matching lines @@
 }
 
 bool ImeMenuTray::ShouldEnableExtraKeyboardAccessibility() {
   return Shell::Get()->accessibility_delegate()->IsSpokenFeedbackEnabled();
 }
 
 void ImeMenuTray::HideBubble(const views::TrayBubbleView* bubble_view) {
   HideBubbleWithView(bubble_view);
 }
 
+bool ImeMenuTray::ProcessGestureEventForBubble(ui::GestureEvent* event) {
+  return drag_controller()->ProcessGestureEvent(*event, this,
+                                                true /* is_on_bubble */);
+}
 void ImeMenuTray::OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) {}
 
 void ImeMenuTray::OnKeyboardClosed() {
   if (InputMethodManager::Get())
     InputMethodManager::Get()->OverrideKeyboardUrlRef(std::string());
   keyboard::KeyboardController* keyboard_controller =
       keyboard::KeyboardController::GetInstance();
   if (keyboard_controller)
     keyboard_controller->RemoveObserver(this);
 
@@ skipping 53 matching lines @@
   else
     label_->SetText(current_ime.short_name);
 }
 
 void ImeMenuTray::DisableVirtualKeyboard() {
   Shell::Get()->accessibility_delegate()->SetVirtualKeyboardEnabled(false);
   force_show_keyboard_ = false;
 }
 
 }  // namespace ash