Touch gestures for System Tray/ IME/ Stylus/ Notifications

ash/system/tray/system_tray.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SYSTEM_TRAY_SYSTEM_TRAY_H_
 #define ASH_SYSTEM_TRAY_SYSTEM_TRAY_H_
 
 #include <map>
 #include <memory>
 #include <vector>
@@ skipping 134 matching lines @@
 
   ScreenTrayItem* GetScreenShareItem() { return screen_share_tray_item_; }
   ScreenTrayItem* GetScreenCaptureItem() { return screen_capture_tray_item_; }
 
   // Activates the system tray bubble.
   void ActivateBubble();
 
   // ui::EventHandler:
   void OnGestureEvent(ui::GestureEvent* event) override;
 
+  // Process a gesture event and updates the dragging state of the bubble when
+  // appropriate. Returns true if the gesture has been handled and it should not
+  // be processed any further, false otherwise. Note, the events may triggered

[xdai1, 2017/06/30 22:27:08]

nit: may be triggered

[minch1, 2017/07/01 05:57:14]

Done.

+  // on system tray or system tray bubble.
+  bool ProcessGestureEvent(const ui::GestureEvent& event, bool is_on_bubble);
+
   gfx::Rect GetWorkAreaBoundsInScreen() const;
 
  private:
   friend class SystemTrayTestApi;
   class ActivationObserver;
 
   // Closes the bubble. Used to bind as a KeyEventWatcher::KeyEventCallback.
   void CloseBubble(const ui::KeyEvent& key_event);
 
   // Activates the bubble and starts key navigation with the |key_event|.
@@ skipping 30 matching lines @@
   void CloseSystemBubbleAndDeactivateSystemTray();
 
   // Records UMA metrics for the number of user-visible rows in the system menu
   // and the percentage of the work area height covered by the system menu.
   void RecordSystemMenuMetrics();
 
   // Overridden from ActionableView.
   bool PerformAction(const ui::Event& event) override;
 
   // Gesture related functions:
-  bool ProcessGestureEvent(const ui::GestureEvent& event);
   bool StartGestureDrag(const ui::GestureEvent& gesture);
   void UpdateGestureDrag(const ui::GestureEvent& gesture);
   void CompleteGestureDrag(const ui::GestureEvent& gesture);
 
-  // Update the bounds of the system tray bubble according to |location|. Note
-  // that |location| is in the local coordinate space of |this|.
-  void SetBubbleBounds(const gfx::Point& location);
+  // Update the bounds of the system tray bubble according to
+  // |gesture_drag_amount_|.
+  void SetBubbleBounds();

[xdai1, 2017/06/30 22:27:08]

I think UpdateBubbleBounds() might better describe the function now.

[minch1, 2017/07/01 05:57:14]

Done.

 
   // Return true if the system bubble should be shown (i.e., animated upward to
   // be made fully visible) after a sequence of scroll events terminated by
   // |sequence_end|. Otherwise return false, indicating that the
   // partially-visible system bubble should be animated downward and made fully
   // hidden.
   bool ShouldShowSystemBubbleAfterScrollSequence(
       const ui::GestureEvent& sequence_end);
 
   // Shelf the system tray is in.
   Shelf* const shelf_;
 
   // The original bounds of the system tray bubble.
   gfx::Rect system_tray_bubble_bounds_;
 
   // Tracks the amount of the drag. Only valid if |is_in_drag_| is true.
   float gesture_drag_amount_ = 0.f;
 
   // True if the user is in the process of gesture-dragging to open the system
   // tray bubble, false otherwise.
   bool is_in_drag_ = false;
 
+  // True if the dragging is on system tray bubble, false otherwise. Note,
+  // should always set this before ProcessGestureEvent.
+  bool is_on_bubble_ = false;

[xdai1, 2017/06/30 22:27:08]

considering rename it to is_dragging_bubble_?

[minch1, 2017/07/01 05:57:13]

There is another flag |is_in_drag_| for dragging state. This one is used to tell
which view the events is triggered on. I think |is_on_bubble_| should be enough.
Let me keep it first.

+
   // The web notification tray view that appears adjacent to this view.
   WebNotificationTray* web_notification_tray_ = nullptr;
 
   // Items.
   std::vector<std::unique_ptr<SystemTrayItem>> items_;
 
   // Pointers to members of |items_|.
   SystemTrayItem* detailed_item_ = nullptr;
 
   // Bubble for default and detailed views.
@@ skipping 27 matching lines @@
   ScreenTrayItem* screen_share_tray_item_ = nullptr;    // not owned
 
   std::unique_ptr<ActivationObserver> activation_observer_;
 
   DISALLOW_COPY_AND_ASSIGN(SystemTray);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SYSTEM_TRAY_SYSTEM_TRAY_H_