Touch gestures for System Tray/ IME/ Stylus/ Notifications

ash/system/tray/system_tray_bubble.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/system_tray_bubble.h"
 
 #include <utility>
 #include <vector>
 
 #include "ash/session/session_controller.h"
@@ skipping 71 matching lines @@
     system_tray_bubble_->Close();
     delete this;
   }
 
  private:
   SystemTrayBubble* system_tray_bubble_ = nullptr;
 
   DISALLOW_COPY_AND_ASSIGN(CloseBubbleObserver);
 };
 
+class SystemTrayBubbleView : public TrayBubbleView {

[sammiequon, 2017/06/30 17:46:02]

I feel it makes more sense to move the bubble related gesture events in here.
That way the bubble handles gestures on the bubble and the tray handles gestures
on the tray, instead of using set_target_view() and passing the gesture event to
the tray view. But that should be work for another CL, if you (or someone else
more familiar with this code) agree.

[xdai1, 2017/06/30 17:51:01]

I have the same feeling too. But I also understand that minch@ wants to reuse
codes in the current implementation. Thus I will defer the decision to the owner
reviewer. 

[minch1, 2017/06/30 19:08:04]

Let's keep it as-is to let owner take a look. Thanks.

+ public:
+  SystemTrayBubbleView(TrayBubbleView::InitParams* init_params,
+                       SystemTray* tray)
+      : TrayBubbleView(*init_params), tray_(tray) {}
+
+  void OnGestureEvent(ui::GestureEvent* event) override {

[sammiequon, 2017/06/30 17:46:02]

nit: // views::View:

[minch1, 2017/06/30 19:08:04]

Done.

+    if (tray_) {
+      tray_->set_target_view(this);
+      if (tray_->ProcessGestureEvent(*event))
+        event->SetHandled();
+    } else {
+      TrayBubbleView::OnGestureEvent(event);
+    }
+  }
+
+ private:
+  SystemTray* tray_;

[sammiequon, 2017/06/30 17:46:02]

nit: // Not owned.

[minch1, 2017/06/30 19:08:04]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(SystemTrayBubbleView);
+};
+
 // SystemTrayBubble
 
 SystemTrayBubble::SystemTrayBubble(
     ash::SystemTray* tray,
     const std::vector<ash::SystemTrayItem*>& items,
     BubbleType bubble_type)
     : tray_(tray),
       bubble_view_(nullptr),
       items_(items),
       bubble_type_(bubble_type),
@@ skipping 134 matching lines @@
       tray_->GetBubbleWindowContainer()->AddChild(clipping_window_.get());
       clipping_window_->Show();
     }
     clipping_window_->SetBounds(tray_->GetWorkAreaBoundsInScreen());
     init_params->parent_window = clipping_window_.get();
   } else {
     init_params->parent_window = tray_->GetBubbleWindowContainer();
   }
 
   init_params->anchor_view = anchor;
-  bubble_view_ = new TrayBubbleView(*init_params);
+  bubble_view_ = new SystemTrayBubbleView(init_params, tray_);
   UpdateBottomPadding();
   bubble_view_->set_adjust_if_offscreen(false);
   CreateItemViews(login_status);
 
   if (bubble_view_->CanActivate()) {
     bubble_view_->NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);
   }
 }
 
 void SystemTrayBubble::DestroyItemViews() {
@@ skipping 125 matching lines @@
     }
   }
 
   if (focus_view) {
     tray_->ActivateBubble();
     focus_view->RequestFocus();
   }
 }
 
 }  // namespace ash