Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 29613004: Sync app order for extension items (Closed)

Created:
7 years, 2 months ago by stevenjb
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Sync app order for extension items This restores syncing app order using the extensions sync to keep ToT behavior in better shape. BUG=306945 R=jennyz@chromium.org, xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229971

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -4 lines) Patch
M chrome/browser/ui/app_list/extension_app_item.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder.h View 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder.cc View 1 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stevenjb
In the interest in reducing the pressure for working out how we are going to ...
7 years, 2 months ago (2013-10-19 01:15:20 UTC) #1
xiyuan
lgtm
7 years, 2 months ago (2013-10-21 16:36:11 UTC) #2
jennyz
lgtm
7 years, 2 months ago (2013-10-21 16:42:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/29613004/30001
7 years, 2 months ago (2013-10-21 17:41:25 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=91289
7 years, 2 months ago (2013-10-22 00:19:52 UTC) #5
stevenjb
7 years, 2 months ago (2013-10-22 00:23:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r229971 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698