Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2961143002: Record only names of instance members in subtypes. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/index.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/index_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-06-28 19:28:41 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-06-28 19:52:24 UTC) #2
scheglov
3 years, 5 months ago (2017-06-28 19:55:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f09be8061505278d5a7092293e8bda57dd2d89a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698