Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 296113011: Add mojo unittests to Windows main waterfall bots. (Closed)

Created:
6 years, 7 months ago by yzshen1
Modified:
6 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

Add mojo unittests to Windows main waterfall bots. BUG=None TEST=None R=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273898

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M testing/buildbot/chromium.win.json View 4 chunks +40 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
yzshen1
Hi, Pawel. Would you please take a look? Thanks!
6 years, 7 months ago (2014-05-22 22:38:03 UTC) #1
Paweł Hajdan Jr.
Windows waterfall is not using this file yet, but should be on Monday. Let's revisit ...
6 years, 7 months ago (2014-05-23 10:51:20 UTC) #2
chromium-reviews
Sure. Thanks! On Fri, May 23, 2014 at 3:51 AM, <phajdan.jr@chromium.org> wrote: > Windows waterfall ...
6 years, 7 months ago (2014-05-23 16:09:13 UTC) #3
yzshen1
Hi, Pawel. I can see that Windows bots have been switched to recipe. Would you ...
6 years, 7 months ago (2014-05-27 16:33:51 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/296113011/diff/1/testing/buildbot/chromium.win.json File testing/buildbot/chromium.win.json (right): https://codereview.chromium.org/296113011/diff/1/testing/buildbot/chromium.win.json#newcode115 testing/buildbot/chromium.win.json:115: "mojo_view_manager_unittests", Tryserver only runs this on Linux (see chromium_trybot.json). ...
6 years, 6 months ago (2014-05-28 12:22:31 UTC) #5
yzshen1
Thanks, Pawel! https://codereview.chromium.org/296113011/diff/1/testing/buildbot/chromium.win.json File testing/buildbot/chromium.win.json (right): https://codereview.chromium.org/296113011/diff/1/testing/buildbot/chromium.win.json#newcode115 testing/buildbot/chromium.win.json:115: "mojo_view_manager_unittests", On 2014/05/28 12:22:31, Paweł Hajdan Jr. ...
6 years, 6 months ago (2014-05-28 16:36:16 UTC) #6
yzshen1
Friendly ping, Pawel.
6 years, 6 months ago (2014-05-30 06:08:26 UTC) #7
Paweł Hajdan Jr.
LGTM
6 years, 6 months ago (2014-05-30 09:00:23 UTC) #8
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 6 months ago (2014-05-30 16:32:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/296113011/40001
6 years, 6 months ago (2014-05-30 16:34:24 UTC) #10
yzshen1
6 years, 6 months ago (2014-05-30 20:04:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 manually as r273898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698