Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 296113009: Revert 272211 "Allow high-res bitmaps to be passed in from notif..." (Closed)

Created:
6 years, 7 months ago by Michael Courage
Modified:
6 years, 7 months ago
Reviewers:
dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272211 "Allow high-res bitmaps to be passed in from notif..." Caused test failure in NotificationsCustomBindingsTest.TestGetUrlSpecs > Allow high-res bitmaps to be passed in from notifications API. > > Previously the custom binding in JS would prevent an image that's larger > than the size of the template from being sent to the browser process. > This relaxes the maximum to be the largest supported scale factor of the machine. > > BUG=239676 > > Review URL: https://codereview.chromium.org/256503004 TBR=dewittj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+670 lines, -921 lines) Patch
M trunk/src/chrome/browser/extensions/api/notifications/notifications_api.cc View 13 chunks +18 lines, -63 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/notifications/notifications_apitest.cc View 3 chunks +615 lines, -15 lines 0 comments Download
M trunk/src/chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/chrome/common/extensions/api/notifications/notification_style.h View 1 chunk +0 lines, -20 lines 0 comments Download
D trunk/src/chrome/common/extensions/api/notifications/notification_style.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M trunk/src/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D trunk/src/chrome/renderer/extensions/notifications_native_handler.h View 1 chunk +0 lines, -42 lines 0 comments Download
D trunk/src/chrome/renderer/extensions/notifications_native_handler.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M trunk/src/chrome/renderer/resources/extensions/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/chrome/renderer/resources/extensions/notifications_custom_bindings.gtestjs View 1 chunk +0 lines, -104 lines 0 comments Download
M trunk/src/chrome/renderer/resources/extensions/notifications_custom_bindings.js View 1 chunk +33 lines, -42 lines 0 comments Download
D trunk/src/chrome/renderer/resources/extensions/notifications_test_util.js View 1 chunk +0 lines, -53 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/notifications/api/basic_usage/background.js View 1 chunk +0 lines, -305 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/notifications/api/basic_usage/manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/api_test/notifications/api/by_user/background.js View 2 chunks +4 lines, -25 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/notifications/api/partial_update/background.js View 1 chunk +0 lines, -141 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/notifications/api/partial_update/manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download
M trunk/src/ui/message_center/message_center_style.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Courage
6 years, 7 months ago (2014-05-22 19:28:34 UTC) #1
Michael Courage
6 years, 7 months ago (2014-05-22 19:28:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r272270 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698