Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: src/arm64/lithium-codegen-arm64.cc

Issue 296113008: Allow HPushArgument to handle more than one argument. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase, and use int instead of unsigned Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/lithium-arm64.cc ('k') | src/arm64/macro-assembler-arm64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "v8.h" 5 #include "v8.h"
6 6
7 #include "arm64/lithium-codegen-arm64.h" 7 #include "arm64/lithium-codegen-arm64.h"
8 #include "arm64/lithium-gap-resolver-arm64.h" 8 #include "arm64/lithium-gap-resolver-arm64.h"
9 #include "code-stubs.h" 9 #include "code-stubs.h"
10 #include "stub-cache.h" 10 #include "stub-cache.h"
(...skipping 4659 matching lines...) Expand 10 before | Expand all | Expand 10 after
4670 4670
4671 GenerateOsrPrologue(); 4671 GenerateOsrPrologue();
4672 } 4672 }
4673 4673
4674 4674
4675 void LCodeGen::DoParameter(LParameter* instr) { 4675 void LCodeGen::DoParameter(LParameter* instr) {
4676 // Nothing to do. 4676 // Nothing to do.
4677 } 4677 }
4678 4678
4679 4679
4680 void LCodeGen::DoPushArgument(LPushArgument* instr) { 4680 void LCodeGen::DoPreparePushArguments(LPreparePushArguments* instr) {
4681 LOperand* argument = instr->value(); 4681 __ PushPreamble(instr->argc(), kPointerSize);
4682 if (argument->IsDoubleRegister() || argument->IsDoubleStackSlot()) {
4683 Abort(kDoPushArgumentNotImplementedForDoubleType);
4684 } else {
4685 __ Push(ToRegister(argument));
4686 after_push_argument_ = true;
4687 }
4688 } 4682 }
4689 4683
4690 4684
4685 void LCodeGen::DoPushArguments(LPushArguments* instr) {
4686 MacroAssembler::PushPopQueue args(masm());
4687
4688 for (int i = 0; i < instr->ArgumentCount(); ++i) {
4689 LOperand* arg = instr->argument(i);
4690 if (arg->IsDoubleRegister() || arg->IsDoubleStackSlot()) {
4691 Abort(kDoPushArgumentNotImplementedForDoubleType);
4692 return;
4693 }
4694 args.Queue(ToRegister(arg));
4695 }
4696
4697 // The preamble was done by LPreparePushArguments.
4698 args.PushQueued(MacroAssembler::PushPopQueue::SKIP_PREAMBLE);
4699
4700 after_push_argument_ = true;
4701 }
4702
4703
4691 void LCodeGen::DoReturn(LReturn* instr) { 4704 void LCodeGen::DoReturn(LReturn* instr) {
4692 if (FLAG_trace && info()->IsOptimizing()) { 4705 if (FLAG_trace && info()->IsOptimizing()) {
4693 // Push the return value on the stack as the parameter. 4706 // Push the return value on the stack as the parameter.
4694 // Runtime::TraceExit returns its parameter in x0. We're leaving the code 4707 // Runtime::TraceExit returns its parameter in x0. We're leaving the code
4695 // managed by the register allocator and tearing down the frame, it's 4708 // managed by the register allocator and tearing down the frame, it's
4696 // safe to write to the context register. 4709 // safe to write to the context register.
4697 __ Push(x0); 4710 __ Push(x0);
4698 __ Ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset)); 4711 __ Ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
4699 __ CallRuntime(Runtime::kTraceExit, 1); 4712 __ CallRuntime(Runtime::kTraceExit, 1);
4700 } 4713 }
(...skipping 1294 matching lines...) Expand 10 before | Expand all | Expand 10 after
5995 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset)); 6008 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset));
5996 // Index is equal to negated out of object property index plus 1. 6009 // Index is equal to negated out of object property index plus 1.
5997 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 6010 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5998 __ Ldr(result, FieldMemOperand(result, 6011 __ Ldr(result, FieldMemOperand(result,
5999 FixedArray::kHeaderSize - kPointerSize)); 6012 FixedArray::kHeaderSize - kPointerSize));
6000 __ Bind(deferred->exit()); 6013 __ Bind(deferred->exit());
6001 __ Bind(&done); 6014 __ Bind(&done);
6002 } 6015 }
6003 6016
6004 } } // namespace v8::internal 6017 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm64/lithium-arm64.cc ('k') | src/arm64/macro-assembler-arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698