Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 296113008: Allow HPushArgument to handle more than one argument. (Closed)

Created:
6 years, 7 months ago by Alexandre Rames
Modified:
6 years, 7 months ago
Reviewers:
ulan, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Allow HPushArgument to handle more than one argument. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21468

Patch Set 1 #

Patch Set 2 : Upload patch of interest only #

Patch Set 3 : Rebase, and use int instead of unsigned #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -80 lines) Patch
M src/arm/lithium-arm.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 2 2 chunks +42 lines, -6 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 2 1 chunk +15 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 1 chunk +20 lines, -7 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 3 chunks +14 lines, -10 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 15 chunks +26 lines, -29 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 2 chunks +50 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M src/lithium.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexandre Rames
The diff includes the diff for issue 296993002 since git cl uploaded everything, but that ...
6 years, 7 months ago (2014-05-22 12:57:03 UTC) #1
Alexandre Rames
6 years, 7 months ago (2014-05-22 12:57:17 UTC) #2
Jakob Kummerow
On 2014/05/22 12:57:03, Alexandre Rames wrote: > The diff includes the diff for issue 296993002 ...
6 years, 7 months ago (2014-05-22 13:01:09 UTC) #3
Alexandre Rames
On 2014/05/22 13:01:09, Jakob wrote: > On 2014/05/22 12:57:03, Alexandre Rames wrote: > > The ...
6 years, 7 months ago (2014-05-22 13:12:43 UTC) #4
ulan
LGTM with one nit: please use "int" instead of "unsigned" where possible to avoid mixing ...
6 years, 7 months ago (2014-05-23 10:31:58 UTC) #5
Alexandre Rames
On 2014/05/23 10:31:58, ulan wrote: > LGTM with one nit: please use "int" instead of ...
6 years, 7 months ago (2014-05-23 12:57:15 UTC) #6
ulan
Yep, lgtm
6 years, 7 months ago (2014-05-23 13:07:01 UTC) #7
Alexandre Rames
6 years, 7 months ago (2014-05-23 14:07:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r21468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698