tools/telemetry/telemetry/page/actions/gesture_action.py - Issue 296113005: Telemetry: IsGestureSourceTypeSupported returns false for touch on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/gesture_action.py

Issue 296113005: Telemetry: IsGestureSourceTypeSupported returns false for touch on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/actions/gesture_action.py

diff --git a/tools/telemetry/telemetry/page/actions/gesture_action.py b/tools/telemetry/telemetry/page/actions/gesture_action.py

index 993c76a76fc52e71974d1eac4dd88cd680e7ac0e..019aa1a0f52daf040041d216c8c1b7600a6c4e42 100644

--- a/tools/telemetry/telemetry/page/actions/gesture_action.py

+++ b/tools/telemetry/telemetry/page/actions/gesture_action.py

@@ -56,7 +56,8 @@ class GestureAction(page_action.PageAction):

if tab.EvaluateJavaScript("""

typeof chrome.gpuBenchmarking.gestureSourceTypeSupported ===

'undefined'"""):

- return True

+ return (tab.browser.platform.GetOSName() != 'mac' or

+ gesture_source_type.lower() != 'touch')

return tab.EvaluateJavaScript("""

chrome.gpuBenchmarking.gestureSourceTypeSupported(

« no previous file with comments | « no previous file | no next file » | no next file with comments »