Make DeleteFile succeed on Windows 7 even if the path contains a nonexistent directory

Make DeleteFile succeed on Windows 7 even if the path contains a nonexistent
diretory.

BUG=375804
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272071

[ericu, 2014-05-21 16:33:51]

Here's that one-liner we discussed yesterday.

[rvargas (doing something else), 2014-05-21 18:01:14]

We should extend FileUtilTest.DeleteNonExistent to cover a non-existing
directory.

https://codereview.chromium.org/296113003/diff/1/base/file_util_win.cc
File base/file_util_win.cc (right):

https://codereview.chromium.org/296113003/diff/1/base/file_util_win.cc#newcod...
base/file_util_win.cc:100: err == 0x7C);
tiny nit: indent under "err"

[ericu, 2014-05-21 18:11:50]

https://codereview.chromium.org/296113003/diff/1/base/file_util_win.cc
File base/file_util_win.cc (right):

https://codereview.chromium.org/296113003/diff/1/base/file_util_win.cc#newcod...
base/file_util_win.cc:100: err == 0x7C);
On 2014/05/21 18:01:14, rvargas wrote:
> tiny nit: indent under "err"

Done.

[ericu, 2014-05-21 18:13:28]

I also added the unit test.

On Wed, May 21, 2014 at 11:11 AM,  <ericu@chromium.org> wrote:
>
> https://codereview.chromium.org/296113003/diff/1/base/file_util_win.cc
> File base/file_util_win.cc (right):
>
>
https://codereview.chromium.org/296113003/diff/1/base/file_util_win.cc#newcod...
> base/file_util_win.cc:100: err == 0x7C);
> On 2014/05/21 18:01:14, rvargas wrote:
>>
>> tiny nit: indent under "err"
>
>
> Done.
>
> https://codereview.chromium.org/296113003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rvargas (doing something else), 2014-05-21 18:14:27]

LGTM

[ericu, 2014-05-21 18:30:59]

The CQ bit was checked by ericu@chromium.org

[commit-bot: I haz the power, 2014-05-21 19:58:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ericu@chromium.org/296113003/10001

[ericu, 2014-05-21 20:23:13]

+brettw as owner.

Brett, this is that error code fix I mentioned yesterday; could you take a quick
look?

Thanks,

	Eric

[brettw, 2014-05-21 20:55:46]

LGTM based on rvargas' review. Just checking that we can't use a constant there?
We should require > Win7 SDK.

[ericu, 2014-05-21 20:58:22]

According to
http://msdn.microsoft.com/en-us/library/windows/desktop/bb762164(v=vs.85).aspx:

"These are pre-Win32 error codes and are no longer supported or
defined in any public header file. To use them, you must either define
them yourself or compare against the numerical value."

Big fun.

On Wed, May 21, 2014 at 1:55 PM,  <brettw@chromium.org> wrote:
> LGTM based on rvargas' review. Just checking that we can't use a constant
> there?
> We should require > Win7 SDK.
>
> https://codereview.chromium.org/296113003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-05-22 03:22:51]

Change committed as 272071