extensions/renderer/bindings/api_last_error.cc - Issue 2961103002: [Extensions Bindings] Add an ExceptionHandler class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/bindings/api_last_error.cc

Issue 2961103002: [Extensions Bindings] Add an ExceptionHandler class (Closed)

Patch Set: rebase + nits Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/bindings/api_last_error.cc

diff --git a/extensions/renderer/bindings/api_last_error.cc b/extensions/renderer/bindings/api_last_error.cc

index 660cab612b5a042a3605f96a3a3da4a6274a4da3..404d140243d9f890ba8bf836b3fe468319568b90 100644

--- a/extensions/renderer/bindings/api_last_error.cc

+++ b/extensions/renderer/bindings/api_last_error.cc

@@ -113,7 +113,7 @@ void LastErrorSetter(v8::Local<v8::Name> property,

} // namespace

APILastError::APILastError(const GetParent& get_parent,

- const AddConsoleError& add_console_error)

+ const binding::AddConsoleError& add_console_error)

: get_parent_(get_parent), add_console_error_(add_console_error) {}

APILastError::APILastError(APILastError&& other) = default;

APILastError::~APILastError() = default;