Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: extensions/renderer/bindings/exception_handler.h

Issue 2961103002: [Extensions Bindings] Add an ExceptionHandler class (Closed)
Patch Set: jbroman's Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/bindings/exception_handler.h
diff --git a/extensions/renderer/bindings/exception_handler.h b/extensions/renderer/bindings/exception_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..dfe39b84393c6f67ef2db3b3c0642dd6b9244e24
--- /dev/null
+++ b/extensions/renderer/bindings/exception_handler.h
@@ -0,0 +1,52 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_RENDERER_BINDINGS_EXCEPTION_HANDLER
+#define EXTENSIONS_RENDERER_BINDINGS_EXCEPTION_HANDLER
+
+#include <string>
+
+#include "base/macros.h"
+#include "base/optional.h"
+#include "extensions/renderer/bindings/api_binding_types.h"
+#include "v8/include/v8.h"
+
+namespace extensions {
+
+// A class to handle uncaught exceptions encountered in the bindings system
+// while running untrusted code, such as exceptions thrown during callback
+// execution or event handling.
+class ExceptionHandler {
+ public:
+ ExceptionHandler(const binding::AddConsoleError& add_console_error,
+ const binding::RunJSFunction& run_js);
+ ~ExceptionHandler();
+
+ // Handles an exception in the given |context|. |message| is a message to
+ // prefix the error message with, e.g. "Exception in response to foo".
+ // The |try_catch| is the TryCatch that caught the exception.
+ void HandleException(v8::Local<v8::Context> context,
+ const std::string& message,
+ v8::TryCatch* try_catch);
+
+ // Sets a custom handler for the given context, which will be notified of
+ // exceptions thrown.
+ void SetHandlerForContext(v8::Local<v8::Context> context,
+ v8::Local<v8::Function> handler);
+
+ private:
+ // Returns the custom handler for the given |context|, or an empty handle if
+ // no custom handle exists.
+ v8::Local<v8::Function> GetCustomHandler(v8::Local<v8::Context> context);
+
+ binding::AddConsoleError add_console_error_;
+
+ binding::RunJSFunction run_js_;
+
+ DISALLOW_COPY_AND_ASSIGN(ExceptionHandler);
+};
+
+} // namespace extensions
+
+#endif // EXTENSIONS_RENDERER_BINDINGS_EXCEPTION_HANDLER

Powered by Google App Engine
This is Rietveld 408576698