Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: extensions/renderer/bindings/api_last_error.h

Issue 2961103002: [Extensions Bindings] Add an ExceptionHandler class (Closed)
Patch Set: jbroman's Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/bindings/api_last_error.h
diff --git a/extensions/renderer/bindings/api_last_error.h b/extensions/renderer/bindings/api_last_error.h
index 1082409ae38d4374b23a619ee7fc00bc7ed26c14..1fb9011343d442fb13315522f507903c7bdeaf47 100644
--- a/extensions/renderer/bindings/api_last_error.h
+++ b/extensions/renderer/bindings/api_last_error.h
@@ -9,6 +9,7 @@
#include "base/callback.h"
#include "base/macros.h"
+#include "extensions/renderer/bindings/api_binding_types.h"
#include "v8/include/v8.h"
namespace extensions {
@@ -26,12 +27,9 @@ class APILastError {
using GetParent = base::Callback<v8::Local<v8::Object>(
v8::Local<v8::Context>,
v8::Local<v8::Object>* secondary_parent)>;
- // Adds an error message to the context's console.
- using AddConsoleError =
- base::Callback<void(v8::Local<v8::Context>, const std::string& error)>;
APILastError(const GetParent& get_parent,
- const AddConsoleError& add_console_error);
+ const binding::AddConsoleError& add_console_error);
APILastError(APILastError&& other);
~APILastError();
@@ -60,7 +58,7 @@ class APILastError {
GetParent get_parent_;
- AddConsoleError add_console_error_;
+ binding::AddConsoleError add_console_error_;
DISALLOW_COPY_AND_ASSIGN(APILastError);
};

Powered by Google App Engine
This is Rietveld 408576698