Omnibox UI Experiments: Implement elide-after-host experiment.

components/url_formatter/url_formatter_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/url_formatter/url_formatter.h"
 
 #include <stddef.h>
 #include <string.h>
 
 #include <vector>
@@ skipping 718 matching lines @@
                                 ? WideToUTF16(idn_cases[i].unicode_output)
                                 : ASCIIToUTF16(idn_cases[i].input));
     EXPECT_EQ(expected, output) << "input # " << i << ": \""
                                 << idn_cases[i].input << "\"";
   }
 }
 
 TEST(UrlFormatterTest, FormatUrl) {
   FormatUrlTypes default_format_type = kFormatUrlOmitUsernamePassword;
   const UrlTestData tests[] = {
-      {"Empty URL", "", default_format_type, net::UnescapeRule::NORMAL, L"",
-       0},
+      {"Empty URL", "", default_format_type, net::UnescapeRule::NORMAL, L"", 0},
 
-      {"Simple URL", "http://www.google.com/",  default_format_type,
+      {"Simple URL", "http://www.google.com/", default_format_type,
        net::UnescapeRule::NORMAL, L"http://www.google.com/", 7},
 
       {"With a port number and a reference",
        "http://www.google.com:8080/#\xE3\x82\xB0", default_format_type,
        net::UnescapeRule::NORMAL, L"http://www.google.com:8080/#\x30B0", 7},
 
       // -------- IDN tests --------
       {"Japanese IDN with ja", "http://xn--l8jvb1ey91xtjb.jp",
        default_format_type, net::UnescapeRule::NORMAL,
        L"http://\x671d\x65e5\x3042\x3055\x3072.jp/", 7},
@@ skipping 33 matching lines @@
        default_format_type, net::UnescapeRule::NORMAL,
        L"mailto:foo@example.com", 7},
 
       // -------- unescape flag tests --------
       {"Do not unescape",
        "http://%E3%82%B0%E3%83%BC%E3%82%B0%E3%83%AB.jp/"
        "%E3%82%B0%E3%83%BC%E3%82%B0%E3%83%AB"
        "?q=%E3%82%B0%E3%83%BC%E3%82%B0%E3%83%AB",
        default_format_type, net::UnescapeRule::NONE,
        // GURL parses %-encoded hostnames into Punycode.
-       L"http://\x30B0\x30FC\x30B0\x30EB.jp/%E3%82%B0%E3%83%BC%E3%82%B0%E3%83%AB"
+       L"http://\x30B0\x30FC\x30B0\x30EB.jp/"
+       L"%E3%82%B0%E3%83%BC%E3%82%B0%E3%83%AB"
        L"?q=%E3%82%B0%E3%83%BC%E3%82%B0%E3%83%AB",
        7},
 
       {"Unescape normally",
        "http://%E3%82%B0%E3%83%BC%E3%82%B0%E3%83%AB.jp/"
        "%E3%82%B0%E3%83%BC%E3%82%B0%E3%83%AB"
        "?q=%E3%82%B0%E3%83%BC%E3%82%B0%E3%83%AB",
        default_format_type, net::UnescapeRule::NORMAL,
        L"http://\x30B0\x30FC\x30B0\x30EB.jp/\x30B0\x30FC\x30B0\x30EB"
        L"?q=\x30B0\x30FC\x30B0\x30EB",
        7},
 
       {"Unescape normally with BiDi control character",
-       "http://example.com/%E2%80%AEabc?q=%E2%80%8Fxy",
-       default_format_type, net::UnescapeRule::NORMAL,
+       "http://example.com/%E2%80%AEabc?q=%E2%80%8Fxy", default_format_type,
+       net::UnescapeRule::NORMAL,
        L"http://example.com/%E2%80%AEabc?q=%E2%80%8Fxy", 7},
 
       {"Unescape normally including unescape spaces",
-       "http://www.google.com/search?q=Hello%20World",
-       default_format_type, net::UnescapeRule::SPACES,
-       L"http://www.google.com/search?q=Hello World", 7},
+       "http://www.google.com/search?q=Hello%20World", default_format_type,
+       net::UnescapeRule::SPACES, L"http://www.google.com/search?q=Hello World",
+       7},
 
       /*
       {"unescape=true with some special characters",
       "http://user%3A:%40passwd@example.com/foo%3Fbar?q=b%26z",
       kFormatUrlOmitNothing, net::UnescapeRule::NORMAL,
       L"http://user%3A:%40passwd@example.com/foo%3Fbar?q=b%26z", 25},
       */
       // Disabled: the resultant URL becomes "...user%253A:%2540passwd...".
 
       // -------- omit http: --------
       {"omit http with user name", "http://user@example.com/foo",
        kFormatUrlOmitAll, net::UnescapeRule::NORMAL, L"example.com/foo", 0},
 
       {"omit http", "http://www.google.com/", kFormatUrlOmitHTTP,
        net::UnescapeRule::NORMAL, L"www.google.com/", 0},
 
-      {"omit http with https", "https://www.google.com/",
-       kFormatUrlOmitHTTP, net::UnescapeRule::NORMAL,
-       L"https://www.google.com/", 8},
+      {"omit http with https", "https://www.google.com/", kFormatUrlOmitHTTP,
+       net::UnescapeRule::NORMAL, L"https://www.google.com/", 8},
 
       {"omit http starts with ftp.", "http://ftp.google.com/",
        kFormatUrlOmitHTTP, net::UnescapeRule::NORMAL, L"http://ftp.google.com/",
        7},
 
       // -------- omit trailing slash on bare hostname --------
       {"omit slash when it's the entire path", "http://www.google.com/",
        kFormatUrlOmitTrailingSlashOnBareHostname, net::UnescapeRule::NORMAL,
        L"http://www.google.com", 7},
       {"omit slash when there's a ref", "http://www.google.com/#ref",
        kFormatUrlOmitTrailingSlashOnBareHostname, net::UnescapeRule::NORMAL,
        L"http://www.google.com/#ref", 7},
       {"omit slash when there's a query", "http://www.google.com/?",
        kFormatUrlOmitTrailingSlashOnBareHostname, net::UnescapeRule::NORMAL,
        L"http://www.google.com/?", 7},
       {"omit slash when it's not the entire path", "http://www.google.com/foo",
-       kFormatUrlOmitTrailingSlashOnBareHostname,
-       net::UnescapeRule::NORMAL, L"http://www.google.com/foo", 7},
+       kFormatUrlOmitTrailingSlashOnBareHostname, net::UnescapeRule::NORMAL,
+       L"http://www.google.com/foo", 7},
       {"omit slash for nonstandard URLs", "data:/",
        kFormatUrlOmitTrailingSlashOnBareHostname, net::UnescapeRule::NORMAL,
        L"data:/", 5},
       {"omit slash for file URLs", "file:///",
        kFormatUrlOmitTrailingSlashOnBareHostname, net::UnescapeRule::NORMAL,
        L"file:///", 7},
 
       // -------- view-source: --------
       {"view-source", "view-source:http://xn--qcka1pmc.jp/",
        default_format_type, net::UnescapeRule::NORMAL,
        L"view-source:http://\x30B0\x30FC\x30B0\x30EB.jp/", 19},
 
       {"view-source of view-source",
-       "view-source:view-source:http://xn--qcka1pmc.jp/",
-       default_format_type, net::UnescapeRule::NORMAL,
+       "view-source:view-source:http://xn--qcka1pmc.jp/", default_format_type,
+       net::UnescapeRule::NORMAL,
        L"view-source:view-source:http://xn--qcka1pmc.jp/", 12},
 
       // view-source should omit http and trailing slash where non-view-source
       // would.
-      {"view-source omit http", "view-source:http://a.b/c",
-       kFormatUrlOmitAll, net::UnescapeRule::NORMAL, L"view-source:a.b/c", 12},
+      {"view-source omit http", "view-source:http://a.b/c", kFormatUrlOmitAll,
+       net::UnescapeRule::NORMAL, L"view-source:a.b/c", 12},
       {"view-source omit http starts with ftp.", "view-source:http://ftp.b/c",
        kFormatUrlOmitAll, net::UnescapeRule::NORMAL,
        L"view-source:http://ftp.b/c", 19},
       {"view-source omit slash when it's the entire path",
-       "view-source:http://a.b/", kFormatUrlOmitAll,
-       net::UnescapeRule::NORMAL, L"view-source:a.b", 12},
+       "view-source:http://a.b/", kFormatUrlOmitAll, net::UnescapeRule::NORMAL,
+       L"view-source:a.b", 12},
+
+      // -------- ellipsize the path --------
+      {"ellipsize path but still strip trailing slashes", "http://google.com/",
+       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+       net::UnescapeRule::NORMAL, L"google.com", 0},
+      {"ellipsize path in simple filename-only case", "http://google.com/foo",
+       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+       net::UnescapeRule::NORMAL, L"google.com/\x2026\x0000", 0},
+      {"ellipsize path in directory and file case", "http://google.com/ab/cd",
+       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+       net::UnescapeRule::NORMAL, L"google.com/\x2026\x0000", 0},
+      {"ellipsize path with query only", "http://google.com/?foo=bar",
+       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+       net::UnescapeRule::NORMAL, L"google.com/\x2026\x0000", 0},
+      {"ellipsize path with ref only", "http://google.com/#foobar",
+       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+       net::UnescapeRule::NORMAL, L"google.com/\x2026\x0000", 0},
+      {"ellipsize path with path and query only", "http://google.com/foo?a=b",
+       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+       net::UnescapeRule::NORMAL, L"google.com/\x2026\x0000", 0},
+      {"ellipsize path with path and ref only", "http://google.com/foo#c",
+       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+       net::UnescapeRule::NORMAL, L"google.com/\x2026\x0000", 0},
+      {"ellipsize path with query and ref only", "http://google.com/?a=b#c",
+       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+       net::UnescapeRule::NORMAL, L"google.com/\x2026\x0000", 0},
+      {"ellipsize path with path, query and ref", "http://google.com/foo?a=b#c",
+       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+       net::UnescapeRule::NORMAL, L"google.com/\x2026\x0000", 0},
+      {"ellipsize URL with repeated delimiters (sanity check)",
+       "http://google.com////???####",
+       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+       net::UnescapeRule::NORMAL, L"google.com/\x2026\x0000", 0},
   };
 
   for (size_t i = 0; i < arraysize(tests); ++i) {
     size_t prefix_len;
     base::string16 formatted = FormatUrl(
         GURL(tests[i].input), tests[i].format_types, tests[i].escape_rules,
         nullptr,  &prefix_len, nullptr);
     EXPECT_EQ(WideToUTF16(tests[i].output), formatted) << tests[i].description;
     EXPECT_EQ(tests[i].prefix_len, prefix_len) << tests[i].description;
   }
@@ skipping 322 matching lines @@
   CheckAdjustedOffsets("http://ftp.google.com/", kFormatUrlOmitHTTP,
                        net::UnescapeRule::NORMAL,
                        omit_http_start_with_ftp_offsets);
 
   const size_t omit_all_offsets[] = {
     0, kNpos, kNpos, kNpos, kNpos, kNpos, kNpos, 0, kNpos, kNpos, kNpos, kNpos,
     0, 1, 2, 3, 4, 5, 6, 7
   };
   CheckAdjustedOffsets("http://user@foo.com/", kFormatUrlOmitAll,
                        net::UnescapeRule::NORMAL, omit_all_offsets);
+
+  const size_t ellipsize_path_offsets[] = {
+      0, kNpos, kNpos, kNpos, kNpos, kNpos, kNpos, 0,     1,     2,     3, 4,
+      5, 6,     7,     8,     kNpos, kNpos, kNpos, kNpos, kNpos, kNpos, 9};

[Peter Kasting, 2017/06/28 20:54:35]

Nit: Is this spacing git cl format's fault?  It's really strange.

[tommycli, 2017/06/28 21:21:39]

Yes, it's from git cl format. I didn't question it. :)

+  CheckAdjustedOffsets("http://foo.com/abcdefg",
+                       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+                       net::UnescapeRule::NORMAL, ellipsize_path_offsets);
+  CheckAdjustedOffsets("http://foo.com/abc/def",
+                       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+                       net::UnescapeRule::NORMAL, ellipsize_path_offsets);
+  CheckAdjustedOffsets("http://foo.com/abc?a=b",
+                       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+                       net::UnescapeRule::NORMAL, ellipsize_path_offsets);
+  CheckAdjustedOffsets("http://foo.com/abc#def",
+                       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+                       net::UnescapeRule::NORMAL, ellipsize_path_offsets);
+  CheckAdjustedOffsets("http://foo.com/a?a=b#f",
+                       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+                       net::UnescapeRule::NORMAL, ellipsize_path_offsets);
+  CheckAdjustedOffsets("http://foo.com//??###",
+                       kFormatUrlOmitAll | kFormatUrlExperimentalEllipsizePath,
+                       net::UnescapeRule::NORMAL, ellipsize_path_offsets);
 }
 
 }  // namespace
 
 }  // namespace url_formatter