chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 2961033002: Use ContainsValue() instead of std::find() in chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 2961033002: Use ContainsValue() instead of std::find() in chrome/browser/extensions (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc ('k') | chrome/browser/extensions/extension_management.cc » ('j') | chrome/browser/extensions/updater/extension_updater.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index 7319aa86e399a38d6007a40fe5cd5a93c138918b..2d708f9dffcac4b4d187ca3eb22f68bcf40cefb7 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -113,8 +113,7 @@ static void EventHandledOnIOThread(

// true if found.

template <typename Collection, typename Key>

bool Contains(const Collection& collection, const Key& key) {

- return std::find(collection.begin(), collection.end(), key) !=

- collection.end();

+ return base::ContainsValue(collection, key);

Devlin 2017/06/30 01:51:59 Here, could we just replace all callers of Contain

Tripta 2017/07/03 05:34:43 Done.

}

// Returns whether |warnings| contains an extension for |extension_id|.