Use ContainsValue() instead of std::find() in chrome/browser/extensions

chrome/browser/extensions/updater/extension_updater.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/updater/extension_updater.h"
 
 #include <stdint.h>
 
-#include <algorithm>
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/rand_util.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
@@ skipping 292 matching lines @@
   for (ExtensionSet::const_iterator extension_iter = extensions->begin();
        extension_iter != extensions->end(); ++extension_iter) {
     const Extension& extension = **extension_iter;
     if (!Manifest::IsAutoUpdateableLocation(extension.location())) {
       VLOG(2) << "Extension " << extension.id() << " is not auto updateable";
       continue;
     }
     // An extension might be overwritten by policy, and have its update url
     // changed. Make sure existing extensions aren't fetched again, if a
     // pending fetch for an extension with the same id already exists.
-    std::list<std::string>::const_iterator pending_id_iter = std::find(
-        pending_ids.begin(), pending_ids.end(), extension.id());
-    if (pending_id_iter == pending_ids.end()) {
+    if (!base::ContainsValue(pending_ids, extension.id())) {
       if (downloader_->AddExtension(extension, request_id, fetch_priority))

[Devlin, 2017/06/30 01:52:00]

nit: not this patch, but maybe combine this with the above?

if (!base::ContainsValue(...) &&
    downloader_->AddExtension(...)) {
  request...
}

[Tripta, 2017/07/03 05:34:44]

Done.

         request.in_progress_ids_.push_back(extension.id());
     }
   }
 }
 
 void ExtensionUpdater::CheckNow(const CheckParams& params) {
   int request_id = next_request_id_++;
 
   VLOG(2) << "Starting update check " << request_id;
   if (params.ids.empty())
@@ skipping 270 matching lines @@
   const InProgressCheck& request = requests_in_progress_[request_id];
   if (request.in_progress_ids_.empty()) {
     VLOG(2) << "Finished update check " << request_id;
     if (!request.callback.is_null())
       request.callback.Run();
     requests_in_progress_.erase(request_id);
   }
 }
 
 }  // namespace extensions