Issue 296093002: Mark SVGElementRareData::m_owner as oilpan-only

Issue 296093002: Mark SVGElementRareData::m_owner as oilpan-only (Closed)

Created:
6 years, 7 months ago by rwlbuis

Modified:
6 years, 7 months ago

Reviewers:
haraken, kouhei (in TOK)

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis, oilpan-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Mark SVGElementRareData::m_owner as oilpan-only Mark SVGElementRareData::m_owner as oilpan-only, it takes extra space for non-oilpan builds. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174485

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	Source/core/svg/SVGElementRareData.h	View		2 chunks	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kouhei (in TOK)

On 2014/05/20 20:30:33, rwlbuis wrote: > PTAL. lgtm

6 years, 7 months ago (2014-05-21 07:54:14 UTC) #2

kouhei (in TOK)

On 2014/05/21 07:54:14, kouhei wrote: > On 2014/05/20 20:30:33, rwlbuis wrote: > > PTAL. > ...

6 years, 7 months ago (2014-05-21 07:54:38 UTC) #3

haraken

LGTM https://codereview.chromium.org/296093002/diff/1/Source/core/svg/SVGElementRareData.h File Source/core/svg/SVGElementRareData.h (right): https://codereview.chromium.org/296093002/diff/1/Source/core/svg/SVGElementRareData.h#newcode153 Source/core/svg/SVGElementRareData.h:153: RawPtrWillBeWeakMember<SVGElement> m_owner; This is only for oilpan, so ...

6 years, 7 months ago (2014-05-21 07:55:50 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/296093002/1

6 years, 7 months ago (2014-05-21 09:49:25 UTC) #6

Message was sent while issue was closed.

Change committed as 174485

Expand Messages | Collapse Messages