Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/ui/views/passwords/manage_password_items_view.cc

Issue 2960843002: Edit button makes username editable in the password manager bubble. (Closed)
Patch Set: Renamed helper function and did forward declaration for view generator functions. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_password_items_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_password_items_view.cc b/chrome/browser/ui/views/passwords/manage_password_items_view.cc
index 6ccdd2ccf2d92a7b38829bc03fbb36453b4dd270..8d0661b7a0b513f9c46b971d0ef7ed1109e97cbc 100644
--- a/chrome/browser/ui/views/passwords/manage_password_items_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_password_items_view.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
#include "chrome/browser/ui/views/harmony/chrome_typography.h"
#include "chrome/grit/generated_resources.h"
+#include "components/password_manager/core/common/password_manager_ui.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/resources/grit/ui_resources.h"
@@ -22,6 +23,7 @@
#include "ui/views/controls/label.h"
#include "ui/views/controls/link.h"
#include "ui/views/controls/link_listener.h"
+#include "ui/views/controls/textfield/textfield.h"
#include "ui/views/layout/fill_layout.h"
#include "ui/views/layout/grid_layout.h"
@@ -70,29 +72,6 @@ void BuildColumnSetIfNeeded(views::GridLayout* layout, int column_set_id) {
}
}
-std::unique_ptr<views::Label> GenerateUsernameLabel(
- const autofill::PasswordForm& form) {
- auto label = base::MakeUnique<views::Label>(GetDisplayUsername(form),
- CONTEXT_DEPRECATED_SMALL);
- label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
- return label;
-}
-
-std::unique_ptr<views::Label> GeneratePasswordLabel(
- const autofill::PasswordForm& form) {
- base::string16 text =
- form.federation_origin.unique()
- ? form.password_value
- : l10n_util::GetStringFUTF16(
- IDS_PASSWORDS_VIA_FEDERATION,
- base::UTF8ToUTF16(form.federation_origin.host()));
- auto label = base::MakeUnique<views::Label>(text, CONTEXT_DEPRECATED_SMALL);
- label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
- if (form.federation_origin.unique())
- label->SetObscured(true);
- return label;
-}
-
std::unique_ptr<views::ImageButton> GenerateDeleteButton(
views::ButtonListener* listener) {
ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
@@ -130,6 +109,36 @@ std::unique_ptr<views::Link> GenerateUndoLink(views::LinkListener* listener) {
} // namespace
+std::unique_ptr<views::Label> GenerateUsernameLabel(
+ const autofill::PasswordForm& form) {
+ auto label = base::MakeUnique<views::Label>(GetDisplayUsername(form),
+ CONTEXT_DEPRECATED_SMALL);
+ label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ return label;
+}
+
+std::unique_ptr<views::Textfield> GenerateUsernameEditable(
+ const autofill::PasswordForm& form) {
+ auto editable = base::MakeUnique<views::Textfield>();
+ editable->SetText(form.username_value);
+ return editable;
+}
+
+std::unique_ptr<views::Label> GeneratePasswordLabel(
+ const autofill::PasswordForm& form) {
+ base::string16 text =
+ form.federation_origin.unique()
+ ? form.password_value
+ : l10n_util::GetStringFUTF16(
+ IDS_PASSWORDS_VIA_FEDERATION,
+ base::UTF8ToUTF16(form.federation_origin.host()));
+ auto label = base::MakeUnique<views::Label>(text, CONTEXT_DEPRECATED_SMALL);
+ label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ if (form.federation_origin.unique())
+ label->SetObscured(true);
+ return label;
+}
+
// Manage credentials: stores credentials state and adds proper row to layout
// based on credential state.
class ManagePasswordItemsView::PasswordFormRow : public views::ButtonListener,

Powered by Google App Engine
This is Rietveld 408576698