Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1606)

Unified Diff: chrome/browser/ui/views/passwords/manage_password_items_view.h

Issue 2960843002: Edit button makes username editable in the password manager bubble. (Closed)
Patch Set: Added new helper function. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_password_items_view.h
diff --git a/chrome/browser/ui/views/passwords/manage_password_items_view.h b/chrome/browser/ui/views/passwords/manage_password_items_view.h
index 66c5819a23123e1c83c2370d635f8417f1f1323a..8b0941f66277e0b4dd4e03269301428599db573d 100644
--- a/chrome/browser/ui/views/passwords/manage_password_items_view.h
+++ b/chrome/browser/ui/views/passwords/manage_password_items_view.h
@@ -10,14 +10,23 @@
#include "base/macros.h"
#include "components/autofill/core/common/password_form.h"
+#include "ui/views/controls/label.h"
+#include "ui/views/controls/textfield/textfield.h"
#include "ui/views/view.h"
class ManagePasswordsBubbleModel;
+// Standalone functions for creating username and password views.
+std::unique_ptr<views::Label> GenerateUsernameLabel(
+ const autofill::PasswordForm& form);
+std::unique_ptr<views::Label> GeneratePasswordLabel(
+ const autofill::PasswordForm& form);
+std::unique_ptr<views::Textfield> GenerateUsernameEditable(
+ const autofill::PasswordForm& form);
+
// A custom view of individual credentials. The view is represented as a table
// where each row can be in three distinct states:
//
-// * Present credentials the user may choose to save.
// * Present already-saved credentials to the user for management.
// * Offer the user the ability to undo a deletion action.
class ManagePasswordItemsView : public views::View {

Powered by Google App Engine
This is Rietveld 408576698