Edit button makes username editable in the password manager bubble.

chrome/browser/ui/views/passwords/manage_password_items_view.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORD_ITEMS_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORD_ITEMS_VIEW_H_
 
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "components/autofill/core/common/password_form.h"
+#include "ui/views/controls/label.h"
+#include "ui/views/controls/textfield/textfield.h"

[vasilii, 2017/07/03 17:15:31]

Label and Textfield can be just forward declared.

[vasilii, 2017/07/06 13:46:42]

Not addressed.

[irmakk, 2017/07/06 14:19:12]

Done.

 #include "ui/views/view.h"
 
 class ManagePasswordsBubbleModel;
 
+// Standalone functions for creating username and password views.
+std::unique_ptr<views::Label> GenerateUsernameLabel(
+    const autofill::PasswordForm& form);
+std::unique_ptr<views::Label> GeneratePasswordLabel(
+    const autofill::PasswordForm& form);
+std::unique_ptr<views::Textfield> GenerateUsernameEditable(
+    const autofill::PasswordForm& form);
+
 // A custom view of individual credentials. The view is represented as a table
 // where each row can be in three distinct states:
 //
 // * Present credentials the user may choose to save.

[vasilii, 2017/07/03 17:15:31]

Obsolete

[irmakk, 2017/07/06 14:19:12]

Done.

 // * Present already-saved credentials to the user for management.
 // * Offer the user the ability to undo a deletion action.
 class ManagePasswordItemsView : public views::View {
  public:
   ManagePasswordItemsView(
       ManagePasswordsBubbleModel* manage_passwords_bubble_model,
       const std::vector<autofill::PasswordForm>* password_forms);
   ManagePasswordItemsView(
       ManagePasswordsBubbleModel* manage_passwords_bubble_model,
       const autofill::PasswordForm* password_form);

[vasilii, 2017/07/03 17:15:31]

I think this is not used anymore. Probably there is other code which is dead now
like some ColumnSets. We should clean it up.

[irmakk, 2017/07/06 14:19:12]

This is still used in the Update Pending View case. Though we can move that case
inside the bubble view with the next cl and i'll remove this constructor then.

 
  private:
   class PasswordFormRow;
 
   ~ManagePasswordItemsView() override;
 
   void AddRows();
   void NotifyPasswordFormStatusChanged(
       const autofill::PasswordForm& password_form, bool deleted);
 
   // Changes the views according to the state of |password_forms_rows_|.
   void Refresh();
 
   std::vector<std::unique_ptr<PasswordFormRow>> password_forms_rows_;
   ManagePasswordsBubbleModel* model_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordItemsView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORD_ITEMS_VIEW_H_