Edit button makes username editable in the password manager bubble.

chrome/browser/ui/views/passwords/manage_password_items_view.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORD_ITEMS_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORD_ITEMS_VIEW_H_
 
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "components/autofill/core/common/password_form.h"
+#include "ui/views/focus/focus_manager.h"

[vasilii, 2017/06/30 15:28:06]

Seems like it's not used in the header?

[irmakk, 2017/07/03 14:56:54]

Done.

 #include "ui/views/view.h"
 
 class ManagePasswordsBubbleModel;
 
 // A custom view of individual credentials. The view is represented as a table
 // where each row can be in three distinct states:
 //
 // * Present credentials the user may choose to save.
 // * Present already-saved credentials to the user for management.
 // * Offer the user the ability to undo a deletion action.
 class ManagePasswordItemsView : public views::View {
  public:
+  class ManagePasswordItemsDelegate {

[vasilii, 2017/06/30 15:28:06]

I'd declare it outside of this class because it's not an internal thing.
Also don't forget to declare a protected virtual destructor.

+   public:
+    virtual void FocusedOnEditable() = 0;
+    virtual void FocusLostOnEditable() = 0;
+  };
+  enum RowStatus { DEFAULT, DELETED, EDITING };

[vasilii, 2017/06/30 15:28:07]

"DEFAULT" isn't clear. I don't understand if it's username,password or
username,password delete

   ManagePasswordItemsView(
       ManagePasswordsBubbleModel* manage_passwords_bubble_model,
       const std::vector<autofill::PasswordForm>* password_forms);
   ManagePasswordItemsView(
       ManagePasswordsBubbleModel* manage_passwords_bubble_model,
-      const autofill::PasswordForm* password_form);
+      const autofill::PasswordForm* password_form,
+      ManagePasswordItemsDelegate* manage_password_items_delegate = nullptr);

[vasilii, 2017/06/30 15:28:06]

I don't think we win anything with the default argument here.

[irmakk, 2017/07/03 14:56:54]

This constructor is also used for the update pending view, but we decided that
our changes will only cover the pending view. I can send the delegate from
update pending view as well but it is not used in that case so i thought it is
better to set a default null ptr.

See
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/passwords/manage...

+  void SetRowStatusForPendingViewRow(RowStatus row_status);

[vasilii, 2017/06/30 15:28:07]

A blank line before please.

[irmakk, 2017/07/03 14:56:54]

Done.

 
  private:
   class PasswordFormRow;
 
   ~ManagePasswordItemsView() override;
 
+  bool OnKeyPressed(const ui::KeyEvent& event) override;

[vasilii, 2017/06/30 15:28:06]

Add a comment // View:

[irmakk, 2017/07/03 14:56:54]

Done.

+
   void AddRows();
   void NotifyPasswordFormStatusChanged(
       const autofill::PasswordForm& password_form, bool deleted);
 
   // Changes the views according to the state of |password_forms_rows_|.
   void Refresh();
 
   std::vector<std::unique_ptr<PasswordFormRow>> password_forms_rows_;
   ManagePasswordsBubbleModel* model_;
+  ManagePasswordItemsDelegate* delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordItemsView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORD_ITEMS_VIEW_H_