Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2960703003: Add a feature flag for network service and about:flags entry for it. (Closed)
Patch Set: more updates Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 67c5e5d64a18b8230867611b904860f3603a688c..ef00a5381d0a17cf4461a049a1d66666d4ce8e68 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -1690,8 +1690,7 @@ void RenderProcessHostImpl::RegisterMojoInterfaces() {
base::Bind(&RenderProcessHostImpl::CreateRendererHost,
base::Unretained(this)));
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableNetworkService)) {
+ if (base::FeatureList::IsEnabled(features::kNetworkService)) {
AddUIThreadInterface(
registry.get(),
base::Bind(&RenderProcessHostImpl::CreateURLLoaderFactory,
@@ -1741,8 +1740,7 @@ void RenderProcessHostImpl::GetAssociatedInterface(
void RenderProcessHostImpl::GetBlobURLLoaderFactory(
mojom::URLLoaderFactoryRequest request) {
- if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableNetworkService)) {
+ if (!base::FeatureList::IsEnabled(features::kNetworkService)) {
NOTREACHED();
return;
}
@@ -1796,8 +1794,7 @@ void RenderProcessHostImpl::CreateRendererHost(
void RenderProcessHostImpl::CreateURLLoaderFactory(
const service_manager::BindSourceInfo& source_info,
mojom::URLLoaderFactoryRequest request) {
- if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableNetworkService)) {
+ if (!base::FeatureList::IsEnabled(features::kNetworkService)) {
NOTREACHED();
return;
}
@@ -2299,7 +2296,6 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(
switches::kEnableLCDText,
switches::kEnableLogging,
switches::kEnableNetworkInformation,
- switches::kEnableNetworkService,
switches::kEnablePinch,
switches::kEnablePluginPlaceholderTesting,
switches::kEnablePreciseMemoryInfo,

Powered by Google App Engine
This is Rietveld 408576698