Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Issue 2960703003: Add a feature flag for network service and about:flags entry for it. (Closed)
Patch Set: more updates Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
index 307d627bbc066e0f292bb1fad86e9fb01a88d0d5..c162cfd0f82d9230692b12415a0f1c1a2a96f284 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
@@ -65,7 +65,7 @@
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/common/content_switches.h"
+#include "content/public/common/content_features.h"
#include "content/public/test/browser_test_utils.h"
#include "crypto/sha2.h"
#include "net/cookies/cookie_store.h"
@@ -1484,10 +1484,8 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, StartAndStop) {
IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, MalwareWebSocketBlocked) {
// This test currently only passes when the network service is enabled.
- if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
- ::switches::kEnableNetworkService)) {
+ if (!base::FeatureList::IsEnabled(features::kNetworkService))
return;
- }
GURL main_url = embedded_test_server()->GetURL(kMalwareWebSocketPage);
// This constructs the URL with the same logic as malware_websocket.html.
GURL resolved = main_url.Resolve("/safe_browsing/malware-ws");
@@ -2257,10 +2255,8 @@ IN_PROC_BROWSER_TEST_F(V4SafeBrowsingServiceTest, CheckBrowseUrl) {
// when the old database backend stops being used.
IN_PROC_BROWSER_TEST_F(V4SafeBrowsingServiceTest, MalwareWebSocketBlocked) {
// This test currently only passes when the network service is enabled.
- if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
- ::switches::kEnableNetworkService)) {
+ if (!base::FeatureList::IsEnabled(features::kNetworkService))
return;
- }
GURL main_url = embedded_test_server()->GetURL(kMalwareWebSocketPage);
// This constructs the URL with the same logic as malware_websocket.html.
GURL resolved = main_url.Resolve("/safe_browsing/malware-ws");

Powered by Google App Engine
This is Rietveld 408576698