Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: pkg/compiler/lib/src/ssa/kernel_impact.dart

Issue 2960633002: Split KernelToElementMap into sub-interfaces (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:kernel/ast.dart' as ir; 5 import 'package:kernel/ast.dart' as ir;
6 6
7 import '../common.dart'; 7 import '../common.dart';
8 import '../common/names.dart'; 8 import '../common/names.dart';
9 import '../compiler.dart'; 9 import '../compiler.dart';
10 import '../constants/expressions.dart'; 10 import '../constants/expressions.dart';
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 if (member == null) { 56 if (member == null) {
57 throw "FOUND NULL FIELD: $element"; 57 throw "FOUND NULL FIELD: $element";
58 } 58 }
59 } else { 59 } else {
60 throw new UnsupportedError("Unsupported element: $element"); 60 throw new UnsupportedError("Unsupported element: $element");
61 } 61 }
62 return member; 62 return member;
63 } 63 }
64 64
65 ResolutionImpact buildKernelImpact( 65 ResolutionImpact buildKernelImpact(
66 ir.Member member, KernelToElementMap elementAdapter) { 66 ir.Member member, KernelToElementMapForImpact elementAdapter) {
67 KernelImpactBuilder builder = new KernelImpactBuilder(elementAdapter, member); 67 KernelImpactBuilder builder = new KernelImpactBuilder(elementAdapter, member);
68 if (member is ir.Procedure) { 68 if (member is ir.Procedure) {
69 return builder.buildProcedure(member); 69 return builder.buildProcedure(member);
70 } else if (member is ir.Constructor) { 70 } else if (member is ir.Constructor) {
71 return builder.buildConstructor(member); 71 return builder.buildConstructor(member);
72 } else if (member is ir.Field) { 72 } else if (member is ir.Field) {
73 return builder.buildField(member); 73 return builder.buildField(member);
74 } 74 }
75 throw new UnsupportedError("Unsupported member: $member"); 75 throw new UnsupportedError("Unsupported member: $member");
76 } 76 }
77 77
78 class KernelImpactBuilder extends ir.Visitor { 78 class KernelImpactBuilder extends ir.Visitor {
79 final ResolutionWorldImpactBuilder impactBuilder; 79 final ResolutionWorldImpactBuilder impactBuilder;
80 final KernelToElementMap elementAdapter; 80 final KernelToElementMapForImpact elementAdapter;
81 final ir.Member currentMember; 81 final ir.Member currentMember;
82 82
83 KernelImpactBuilder(this.elementAdapter, this.currentMember) 83 KernelImpactBuilder(this.elementAdapter, this.currentMember)
84 : this.impactBuilder = 84 : this.impactBuilder =
85 new ResolutionWorldImpactBuilder('${currentMember.name}'); 85 new ResolutionWorldImpactBuilder('${currentMember.name}');
86 86
87 CommonElements get commonElements => elementAdapter.commonElements; 87 CommonElements get commonElements => elementAdapter.commonElements;
88 88
89 /// Add a checked-mode type use of [type] if it is not `dynamic`. 89 /// Add a checked-mode type use of [type] if it is not `dynamic`.
90 DartType checkType(ir.DartType irType) { 90 DartType checkType(ir.DartType irType) {
(...skipping 521 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 ConstructorEntity target = elementAdapter.getConstructor(node.target); 612 ConstructorEntity target = elementAdapter.getConstructor(node.target);
613 impactBuilder.registerStaticUse(new StaticUse.superConstructorInvoke( 613 impactBuilder.registerStaticUse(new StaticUse.superConstructorInvoke(
614 target, elementAdapter.getCallStructure(node.arguments))); 614 target, elementAdapter.getCallStructure(node.arguments)));
615 } 615 }
616 616
617 // TODO(johnniwinther): Make this throw and visit child nodes explicitly 617 // TODO(johnniwinther): Make this throw and visit child nodes explicitly
618 // instead to ensure that we don't visit unwanted parts of the ir. 618 // instead to ensure that we don't visit unwanted parts of the ir.
619 @override 619 @override
620 void defaultNode(ir.Node node) => node.visitChildren(this); 620 void defaultNode(ir.Node node) => node.visitChildren(this);
621 } 621 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698