Split KernelToElementMap into sub-interfaces

Split KernelToElementMap into sub-interfaces

This prepares for a more direct implementation of J-elements by
splitting out the parts needed for world-impact vs ssa-building.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/e7ba4959caaea53a8db5ac8aab0ebb47b8ac88cd

[Johnni Winther, 2017-06-26 14:16:11]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-26 18:05:41]

lgtm

https://codereview.chromium.org/2960633002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map.dart (right):

https://codereview.chromium.org/2960633002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map.dart:105: abstract class
KernelToElementMapForImpact implements KernelToElementMap {
nit: any reason to use `implements` as opposed to `extends` here? I tend to use
extends for this purpose as well.

https://codereview.chromium.org/2960633002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (left):

https://codereview.chromium.org/2960633002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:1842: ConstructorEntity
getSuperConstructor(
this means that jstoelement-map doesn't need this?

[Johnni Winther, 2017-06-27 08:26:31]

https://codereview.chromium.org/2960633002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map.dart (right):

https://codereview.chromium.org/2960633002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map.dart:105: abstract class
KernelToElementMapForImpact implements KernelToElementMap {
On 2017/06/26 18:05:41, Siggi Cherem (dart-lang) wrote:
> nit: any reason to use `implements` as opposed to `extends` here? I tend to
use
> extends for this purpose as well.

Nah.

https://codereview.chromium.org/2960633002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (left):

https://codereview.chromium.org/2960633002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:1842: ConstructorEntity
getSuperConstructor(
On 2017/06/26 18:05:41, Siggi Cherem (dart-lang) wrote:
> this means that jstoelement-map doesn't need this?

I think it might. We haven't handled explicit super-constructor calls yet. We
re-insert it if necessary.

[Johnni Winther, 2017-06-27 08:28:35]

Description was changed from

==========
Split KernelToElementMap into sub-interfaces

This prepares for a more direct implementation of J-elements by
splitting out the parts needed for world-impact vs ssa-building.
==========

to

==========
Split KernelToElementMap into sub-interfaces

This prepares for a more direct implementation of J-elements by
splitting out the parts needed for world-impact vs ssa-building.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e7ba4959caaea53a8db5ac8aab0ebb47b8ac88cd
==========

[Johnni Winther, 2017-06-27 08:28:36]

Committed patchset #2 (id:20001) manually as
e7ba4959caaea53a8db5ac8aab0ebb47b8ac88cd (presubmit successful).